Zizmor fixes#889
Open
bckohan wants to merge 8 commits intodjango-commons:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes remaining Zizmor audit findings across GitHub Actions CI workflows by tightening permissions and improving workflow-run safety (concurrency), with an additional lockfile refresh.
Changes:
- Added
concurrencygroups to multiple workflows to prevent duplicate overlapping runs. - Replaced broad
read-allpermissions with least-privilegecontents: read(and narrowed job-level permissions where needed). - Updated
update_coc.ymlPR-creation approach (now usesgh+ git push) and pinned one Postgres service image entry by digest.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Updates locked dependency versions (jedi/parso/psycopg). |
.github/workflows/zizmor.yml |
Adds concurrency; clarifies security-events: write usage. |
.github/workflows/update_coc.yml |
Tightens permissions, adds concurrency, switches PR creation implementation. |
.github/workflows/test.yml |
Adds concurrency, removes actions: write, pins one Postgres matrix entry by digest. |
.github/workflows/scorecard.yml |
Replaces read-all with least-privilege permissions + concurrency. |
.github/workflows/release.yml |
Replaces read-all/removes extra permissions; retains required OIDC permissions. |
.github/workflows/lint.yml |
Adds concurrency and job name. |
.github/workflows/bandit.yml |
Adds concurrency; clarifies security-events: write usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+61
to
+65
| git checkout -B "$BRANCH" | ||
| git add CODE_OF_CONDUCT.md | ||
| git commit -m "Update Code of Conduct" | ||
| git push --force-with-lease origin "$BRANCH" | ||
|
|
Comment on lines
+66
to
+70
| gh pr view "$BRANCH" >/dev/null 2>&1 || gh pr create \ | ||
| --base "$REF_NAME" \ | ||
| --head "$BRANCH" \ | ||
| --title "Update Code of Conduct" \ | ||
| --body "Automated update." |
Comment on lines
51
to
54
| matrix: | ||
| python-version: ['3.10', '3.11', '3.12', '3.13', '3.14'] | ||
| postgres-version: ['12', '14', 'latest'] | ||
| postgres-version: ['12', '14@sha256:bbb8851608e3ff4901156bf6a4bf90735a9d44ae014c03811bfdb2f9c354b18b', 'latest'] | ||
| psycopg-version: ['psycopg2', 'psycopg3'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix all remaining zizmor findings for CI workflows using the auditor persona.