Make worker compatible with Windows#335
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Pull request overview
This PR aims to make the scheduler worker behave correctly on Windows by avoiding Unix-only APIs and selecting an appropriate timeout (“death penalty”) implementation based on platform capabilities.
Changes:
- Guard job forking so it’s only used when
os.forkexists, otherwise run jobs in-process. - Replace
os.uname()[1]withsocket.gethostname()for cross-platform worker naming. - Select the default death-penalty implementation dynamically (SIGALRM-based vs timer-based).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scheduler/worker/worker.py |
Avoids Unix-only fork() usage when unavailable; uses socket.gethostname() for worker naming. |
scheduler/types/settings_types.py |
Switches config default from a hard-coded Unix death penalty class to a platform-derived default. |
scheduler/helpers/timeouts.py |
Introduces a helper to choose the default death penalty class based on SIGALRM availability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make worker compatible with Windows with three changes:
os.uname()[1]withsocket.gethostname()os.forkis available