[Work-in-Progress] Generate weekly report with new submissions(#427)#434
Open
Deep-Chill wants to merge 3 commits into
Open
[Work-in-Progress] Generate weekly report with new submissions(#427)#434Deep-Chill wants to merge 3 commits into
Deep-Chill wants to merge 3 commits into
Conversation
Contributor
Deep-Chill
commented
Jan 16, 2024
Deep-Chill
commented
- Created command to list suppliers that have completed a specific survey during a specified period for a campaign.
…in#427) - Created command to list suppliers that have completed a specific survey during a specified period for a campaign.
- Preliminary version of updated logic in the completed_assessments command to allow specifying a grantee.
smirolo
approved these changes
Jan 22, 2024
Contributor
smirolo
left a comment
smirolo
left a comment
There was a problem hiding this comment.
just commenting for reference. code looks good.
| action='store', | ||
| help='Slug of grantee') | ||
| parser.add_argument('--grantees', | ||
| nargs='+', |
Contributor
There was a problem hiding this comment.
That's interesting. As a convention so far we had used repetition of the command line parameter, i.e. python manage.py command --grantee grantee1 --grantee grantee2 .... Here it seems the convention is python manage.py command --grantees grantee1,grantee2 ...
| return segments_query | ||
|
|
||
| def get_portfolios_frozen_assessments(grantee=None, | ||
| def get_portfolios_frozen_assessments(grantees=None, |
Contributor
There was a problem hiding this comment.
This implementation looks like a specific version of the implementation in PortfolioAccessibleSamplesMixin.get_latest_frozen_by_accounts_by_period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.