[Work-in-Progress] New UI#452
Open
Deep-Chill wants to merge 4 commits into
Open
Conversation
This is a WIP implementation of the UI changes.
'new_assess' is a test directory, it'll replace the code in app/assess and app/scorecard in the final version.
new_assess/scorecard/index.html is the current working file.
Currently working on:
- [ ] Move all the current changes to the original views/templates
- [ ] Recheck Vue and View to ensure compatbility
- [ ] Vue
- [ ] Issue with url/itemlistmixin, maybe the best solution would be to use the existing campaign-questions-list and scorecard components.
- [ ] View is clashing with prefix and itemlistmixin
- [ ] Fix chart
- [ ] Missing the first item in the scorecard
- [ ] Fix scorecard showing before assessment on page load
- [ ] Scorecard should calculate on a new assessment when we switch to the assess mode. It should instantly calculate based on toggle.
- [ ] Change prefix upon toggling view to empty string
- [ ] Improved logic for switching between the assess and the scorecard in the template
- [ ] remove the checkmarks
- [ ] practiceslistmixin is creating the chart and calling all the other methods before they’re necessary
- [ ] Preload scorecard
- [x] Set sidebar buttons to open the tile
- [ ] Use implemented divs instead of tables
- Instead of creating a new component that merges everything in the campaign-questions-list and scorecard components, this code is using the existing components with slight modifications and using keep-alive to keep both of them alive. - A new smaller component (currently) named `new-assess` is used to keep track of the sidebar. - The main html file is `new_assess/scorecard/index.html` and the view is in `views/new_assess.py` Currently working on: - Investigating why a new sample is created whenever an assessment gets frozen. - Adding Share assessment button - Replacing tables with divs. Need clarifications on: - the exact behavior once a sample gets frozen and where the user should be redirected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP implementation of the UI changes.
'new_assess' is a test directory, it'll replace the code in app/assess and app/scorecard in the final version.
new_assess/scorecard/index.html is the current working file.
Currently working on: