Merge pull request #272 from djensenius/add-lint-job

Forgot to add the lint job

Author: djensenius

.github/workflows/actionlint.yml

@@ -1,9 +1,6 @@
 ---
 name: Lint GitHub Actions
 on:  # yamllint disable-line rule:truthy
-  push:
-    paths:
-      - .github/workflows/**.yml
   pull_request:
     paths:
       - .github/workflows/**.yml

.github/workflows/fishlint.yml

@@ -1,7 +1,6 @@
 ---
 name: 'Lint Fish Files'
 on:  # yamllint disable-line rule:truthy
-  - push
   - pull_request
 jobs:
   fishlint:

.github/workflows/lualint.yml

@@ -1,6 +1,6 @@
 ---
 name: Lint Lua files
-on: [push, pull_request]  # yamllint disable-line rule:truthy
+on: pull_request  # yamllint disable-line rule:truthy
 jobs:
   Lint:
     runs-on: ubuntu-latest

.github/workflows/shellcheck.yml

@@ -0,0 +1,13 @@
+---
+name: 'Lint Shell Scripts'
+on:  # yamllint disable-line rule:truthy
+  - pull_request
+jobs:
+  shellcheck:
+    name: 'Shellcheck'
+    runs-on: ubuntu-latest
+    steps:
+      - name: 'Checkout'
+        uses: actions/checkout@v4
+      - name: 'Shellcheck'
+        uses: ludeeus/action-shellcheck@master

.github/workflows/stylua.yml

@@ -1,6 +1,6 @@
 ---
 name: StyLua files
-on: [push, pull_request]  # yamllint disable-line rule:truthy
+on: pull_request  # yamllint disable-line rule:truthy
 jobs:
   run:
     runs-on: ubuntu-latest

.github/workflows/tomllint.yml

@@ -1,9 +1,6 @@
 ---
 name: Lint TOML Files
 on:  # yamllint disable-line rule:truthy
-  push:
-    paths:
-      - "**/*.toml"
   pull_request:
     paths:
       - "**/*.toml"

install.sh

@@ -49,6 +49,7 @@ done
 
 if [[ "$PARALLEL_MODE" == "true" ]]; then
     # Source parallel installation framework
+    # shellcheck disable=SC1091
     source "$(dirname "$0")/scripts/parallel-install.sh"
     echo "🚀 Parallel installation mode enabled"
 else
@@ -137,7 +138,7 @@ generate_timing_summary() {
         } >> "$LOG_FILE"
     fi
 
-    echo "Completed: $(date)" >> $LOG_FILE
+    echo "Completed: $(date)" >> "$LOG_FILE"
 }
 
 function link_files() {
@@ -774,24 +775,24 @@ function start_git_status_background() {
 }
 
 # shellcheck disable=SC2031
-echo '🔗 Starting file linking phase' >> $LOG_FILE
+echo '🔗 Starting file linking phase' >> "$LOG_FILE"
 link_files_start=$(date +%s)
 link_files
 log_with_timing "🔗 File linking phase" "$link_files_start"
 
 # shellcheck disable=SC2031
-echo '💽 Starting software installation phase' >> $LOG_FILE
+echo '💽 Starting software installation phase' >> "$LOG_FILE"
 install_software_start=$(date +%s)
 install_software
 log_with_timing "💽 Software installation phase" "$install_software_start"
 
 # shellcheck disable=SC2031
-echo '👩‍🔧 Starting software configuration phase' >> $LOG_FILE
+echo '👩‍🔧 Starting software configuration phase' >> "$LOG_FILE"
 setup_software_start=$(date +%s)
 setup_software
 log_with_timing "👩‍🔧 Software configuration phase" "$setup_software_start"
 
 # shellcheck disable=SC2031
-echo '✅ Installation completed successfully!' >> $LOG_FILE
+echo '✅ Installation completed successfully!' >> "$LOG_FILE"
 generate_timing_summary
 

scripts/demo-parallel.sh

@@ -10,6 +10,7 @@ echo "cargo package installations with shorter delays."
 echo ""
 
 # Source the parallel installation framework
+# shellcheck disable=SC1091
 source "$(dirname "$0")/parallel-install.sh"
 
 # Demo cargo installation with simulated delays