From 2701c53cc03b949dbe218d8481ce485c98d31e6d Mon Sep 17 00:00:00 2001
From: David Jensenius <david@jensenius.com>
Date: Fri, 5 Dec 2025 16:15:08 -0500
Subject: [PATCH 1/3] Forgot to add the lint job

---
 .github/workflows/shellcheck.yml | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 .github/workflows/shellcheck.yml

diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml
new file mode 100644
index 0000000..5585fb0
--- /dev/null
+++ b/.github/workflows/shellcheck.yml
@@ -0,0 +1,13 @@
+---
+name: 'Lint Shell Scripts'
+on:  # yamllint disable-line rule:truthy
+  - pull_request
+jobs:
+  shellcheck:
+    name: 'Shellcheck'
+    runs-on: ubuntu-latest
+    steps:
+      - name: 'Checkout'
+        uses: actions/checkout@v4
+      - name: 'Shellcheck'
+        uses: ludeeus/action-shellcheck@master

From f5299eae3631b75ce4bbbaefe3a6831348f00afd Mon Sep 17 00:00:00 2001
From: David Jensenius <david@jensenius.com>
Date: Fri, 5 Dec 2025 16:17:43 -0500
Subject: [PATCH 2/3] Fix rest of failed linting

---
 install.sh               | 11 ++++++-----
 scripts/demo-parallel.sh |  1 +
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/install.sh b/install.sh
index 67b739d..9c01bd4 100755
--- a/install.sh
+++ b/install.sh
@@ -49,6 +49,7 @@ done
 
 if [[ "$PARALLEL_MODE" == "true" ]]; then
     # Source parallel installation framework
+    # shellcheck disable=SC1091
     source "$(dirname "$0")/scripts/parallel-install.sh"
     echo "🚀 Parallel installation mode enabled"
 else
@@ -137,7 +138,7 @@ generate_timing_summary() {
         } >> "$LOG_FILE"
     fi
     
-    echo "Completed: $(date)" >> $LOG_FILE
+    echo "Completed: $(date)" >> "$LOG_FILE"
 }
 
 function link_files() {
@@ -774,24 +775,24 @@ function start_git_status_background() {
 }
 
 # shellcheck disable=SC2031
-echo '🔗 Starting file linking phase' >> $LOG_FILE
+echo '🔗 Starting file linking phase' >> "$LOG_FILE"
 link_files_start=$(date +%s)
 link_files
 log_with_timing "🔗 File linking phase" "$link_files_start"
 
 # shellcheck disable=SC2031
-echo '💽 Starting software installation phase' >> $LOG_FILE
+echo '💽 Starting software installation phase' >> "$LOG_FILE"
 install_software_start=$(date +%s)
 install_software
 log_with_timing "💽 Software installation phase" "$install_software_start"
 
 # shellcheck disable=SC2031
-echo '👩‍🔧 Starting software configuration phase' >> $LOG_FILE
+echo '👩‍🔧 Starting software configuration phase' >> "$LOG_FILE"
 setup_software_start=$(date +%s)
 setup_software
 log_with_timing "👩‍🔧 Software configuration phase" "$setup_software_start"
 
 # shellcheck disable=SC2031
-echo '✅ Installation completed successfully!' >> $LOG_FILE
+echo '✅ Installation completed successfully!' >> "$LOG_FILE"
 generate_timing_summary
 
diff --git a/scripts/demo-parallel.sh b/scripts/demo-parallel.sh
index d51910b..72e597e 100755
--- a/scripts/demo-parallel.sh
+++ b/scripts/demo-parallel.sh
@@ -10,6 +10,7 @@ echo "cargo package installations with shorter delays."
 echo ""
 
 # Source the parallel installation framework
+# shellcheck disable=SC1091
 source "$(dirname "$0")/parallel-install.sh"
 
 # Demo cargo installation with simulated delays

From 872b1b47c13d9d0d3f2b6eff452eb7b47f6a9635 Mon Sep 17 00:00:00 2001
From: David Jensenius <david@jensenius.com>
Date: Fri, 5 Dec 2025 16:20:55 -0500
Subject: [PATCH 3/3] Only run actions on PRs

---
 .github/workflows/actionlint.yml | 3 ---
 .github/workflows/fishlint.yml   | 1 -
 .github/workflows/lualint.yml    | 2 +-
 .github/workflows/stylua.yml     | 2 +-
 .github/workflows/tomllint.yml   | 3 ---
 5 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml
index 04a5eae..9d15f71 100644
--- a/.github/workflows/actionlint.yml
+++ b/.github/workflows/actionlint.yml
@@ -1,9 +1,6 @@
 ---
 name: Lint GitHub Actions
 on:  # yamllint disable-line rule:truthy
-  push:
-    paths:
-      - .github/workflows/**.yml
   pull_request:
     paths:
       - .github/workflows/**.yml
diff --git a/.github/workflows/fishlint.yml b/.github/workflows/fishlint.yml
index 1d3ae22..e6bafbf 100644
--- a/.github/workflows/fishlint.yml
+++ b/.github/workflows/fishlint.yml
@@ -1,7 +1,6 @@
 ---
 name: 'Lint Fish Files'
 on:  # yamllint disable-line rule:truthy
-  - push
   - pull_request
 jobs:
   fishlint:
diff --git a/.github/workflows/lualint.yml b/.github/workflows/lualint.yml
index cb8f1d9..02b607e 100644
--- a/.github/workflows/lualint.yml
+++ b/.github/workflows/lualint.yml
@@ -1,6 +1,6 @@
 ---
 name: Lint Lua files
-on: [push, pull_request]  # yamllint disable-line rule:truthy
+on: pull_request  # yamllint disable-line rule:truthy
 jobs:
   Lint:
     runs-on: ubuntu-latest
diff --git a/.github/workflows/stylua.yml b/.github/workflows/stylua.yml
index 0154293..2bff5bf 100644
--- a/.github/workflows/stylua.yml
+++ b/.github/workflows/stylua.yml
@@ -1,6 +1,6 @@
 ---
 name: StyLua files
-on: [push, pull_request]  # yamllint disable-line rule:truthy
+on: pull_request  # yamllint disable-line rule:truthy
 jobs:
   run:
     runs-on: ubuntu-latest
diff --git a/.github/workflows/tomllint.yml b/.github/workflows/tomllint.yml
index 1079bce..bffb85c 100644
--- a/.github/workflows/tomllint.yml
+++ b/.github/workflows/tomllint.yml
@@ -1,9 +1,6 @@
 ---
 name: Lint TOML Files
 on:  # yamllint disable-line rule:truthy
-  push:
-    paths:
-      - "**/*.toml"
   pull_request:
     paths:
       - "**/*.toml"