Use AWS_LC_SYS_CMAKE_BUILDER#290
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the installation commands for several Rust-based tools to ensure compatibility with AWS's
aws-lccryptography library when building via Cargo. The changes mainly involve setting theAWS_LC_SYS_CMAKE_BUILDER=1environment variable for specific tools during installation, both in serial and parallel scripts.Updates to installation commands for AWS compatibility:
AWS_LC_SYS_CMAKE_BUILDER=1to the Cargo install commands foratuinin bothinstall.shandscripts/parallel-install.sh, ensuring it builds correctly with AWS's cryptography library. [1] [2] [3] [4]zellijandcloudflare-speed-clito includeAWS_LC_SYS_CMAKE_BUILDER=1, across all relevant parallel and background installation functions inscripts/parallel-install.sh. [1] [2] [3] [4]These changes help prevent build issues for these tools in environments where AWS's cryptography library is required.