Skip to content

fix: move mise security settings to fish env#322

Merged
djensenius merged 1 commit into
mainfrom
fix-mise-symlink-security-settings
Jun 20, 2026
Merged

fix: move mise security settings to fish env#322
djensenius merged 1 commit into
mainfrom
fix-mise-symlink-security-settings

Conversation

@djensenius

Copy link
Copy Markdown
Owner

Summary

  • move mise security-sensitive settings out of the symlinked repo TOML config
  • export those settings from fish before mise initializes
  • keep mise tool/version config in mise/config.toml

Validation

  • yamllint on tracked YAML files
  • tomllint on tracked TOML files
  • fish --no-execute on tracked fish files
  • fish_indent formatting check on tracked fish files
  • actionlint

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves mise security-sensitive configuration (trust roots and GitHub credential command) out of the symlinked mise/config.toml and into Fish environment variables set before mise initialization, keeping the TOML focused on tool/version configuration.

Changes:

  • Removed trusted_config_paths, [settings.github].credential_command, and related interactive settings from mise/config.toml.
  • Exported the equivalent mise settings via MISE_* environment variables in fish/config.fish ahead of mise activate.
  • Preserved the existing “initialize mise early” flow so tools remain available across shells.
Show a summary per file
File Description
mise/config.toml Removes security-sensitive/trust-related settings from the repo-symlinked mise config.
fish/config.fish Exports mise trust + GitHub credential settings via environment before mise initialization.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@djensenius djensenius merged commit 54def63 into main Jun 20, 2026
7 checks passed
@djensenius djensenius deleted the fix-mise-symlink-security-settings branch June 20, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants