fix: move mise security settings to fish env#322
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves mise security-sensitive configuration (trust roots and GitHub credential command) out of the symlinked mise/config.toml and into Fish environment variables set before mise initialization, keeping the TOML focused on tool/version configuration.
Changes:
- Removed
trusted_config_paths,[settings.github].credential_command, and related interactive settings frommise/config.toml. - Exported the equivalent mise settings via
MISE_*environment variables infish/config.fishahead ofmise activate. - Preserved the existing “initialize mise early” flow so tools remain available across shells.
Show a summary per file
| File | Description |
|---|---|
mise/config.toml |
Removes security-sensitive/trust-related settings from the repo-symlinked mise config. |
fish/config.fish |
Exports mise trust + GitHub credential settings via environment before mise initialization. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation