Remove OSC94 tmux pludin, add wc26 config#331
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables the OSC 9;4 tmux progress-flag plugin (commenting it out rather than deleting it) and introduces initial personal configuration for a new tool, worldcup26, plus a matching Nerd Font icon so its tmux window is visually identifiable. It is a low-risk, config-only change within this dotfiles repository.
Changes:
- Comment out the
djensenius/tmux-osc-9-4plugin and all related@osc94_*settings (including the animation daemon) intmux/tmux.conf. - Add
worldcup26/config.tomlwith favorites, provider selection, and UI preferences (theme, Nerd Fonts, flags, timezone). - Add a
worldcup26icon mapping totmux/tmux-nerd-font-window-name.yml.
Show a summary per file
| File | Description |
|---|---|
tmux/tmux.conf |
Comments out the OSC 9;4 plugin, its options, and the animation daemon invocation. |
worldcup26/config.toml |
New, valid TOML config defining favorites, provider, and UI settings for the worldcup26 tool. |
tmux/tmux-nerd-font-window-name.yml |
Adds a quoted Nerd Font glyph entry for worldcup26, consistent with existing icon entries. |
Notes for the author (no in-diff blocking issues found):
- After disabling
@osc94_animate, the#{@osc94_flag}reference still present ontmux.conf:40will simply resolve to an empty string since the daemon no longer sets that option. It is harmless but is now dead and could be cleaned up for clarity (it falls outside this PR's changed lines). worldcup26/config.tomlis not symlinked byinstall.sh'slink_files. Since that tool is described as macOS-only andinstall.shis largely Codespaces-focused, this may be intentional; just confirm the file is linked into~/.config/worldcup26/by your macOS setup so it gets auto-loaded.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces initial support for a new tool called
worldcup26, including its configuration file, adds a corresponding icon for it in the tmux Nerd Font window name configuration, and comments out the OSC 9;4 plugin and related settings in the tmux configuration.New tool support and configuration:
worldcup26/config.tomlwith options for favorite teams, data provider selection, and UI preferences such as theme, icon fonts, and timezone.Tmux integration updates:
worldcup26intmux/tmux-nerd-font-window-name.ymlto support visual identification in tmux window names.tmux.conf, disabling animated per-window progress flags and OSC 9;4 features.