feat: hide tab bar when only one tab, wire up File menu Save/Save As/Save All

Author: djwisdom

TESTS.md

@@ -0,0 +1,42 @@
+# pcode-editor Test Suite
+
+## Test 1: Build Test
+```bash
+cd build
+cmake --build . --config Release
+```
+**Expected**: Build completes without errors
+
+## Test 2: Menu Functionality
+1. Run the app: `build/Release/pcode-editor.exe`
+2. Click on "File" menu in menu bar
+3. Click on "Edit" menu
+4. Click on "View" menu
+**Expected**: Menus should open and show menu items
+
+## Test 3: Features Test
+After confirming menus work, test these features:
+
+| Feature | Test Steps | Expected |
+|---------|------------|----------|
+| Line Numbers | View menu → toggle Line Numbers | Line numbers show/hide |
+| Whitespace | View menu → toggle Whitespace | Space dots show/hide |
+| Code Folding | View menu → toggle Code Folding | Toggle enabled |
+| Bookmarks | View menu → toggle Bookmarks | Toggle visible |
+| Change Markers | View menu → toggle Change Markers | Toggle visible |
+| Theme | View menu → toggle Dark/Light Theme | Colors change |
+| Zoom | Ctrl++ / Ctrl+- / Ctrl+0 | Font size changes |
+| Code Folding Hotkey | Ctrl+Shift+O on line with `{` | Line folds |
+| Unfold Hotkey | Ctrl+Shift+[ | Line unfolds |
+
+## Test 4: File Operations
+1. File → Open → select a .cpp file
+2. File → Save (Ctrl+S)
+3. File → Save As → different name
+4. Close tab with X button
+
+## Test 5: Editor Operations
+1. Type some text
+2. Ctrl+F to find
+3. Ctrl+H to replace
+4. Ctrl+G to go to line

src/editor_app.cpp

@@ -899,10 +899,14 @@ void EditorApp::render_menu_file() {
                         open_file(settings_.recent_files[i]);
                     }
                 }
-ImGui::EndMenu();
+                ImGui::EndMenu();
             }
         }
 
+        ImGui::Separator();
+        if (ImGui::MenuItem("Save", "Ctrl+S")) save_tab(active_tab_);
+        if (ImGui::MenuItem("Save As...", "Ctrl+Shift+S")) save_tab_as(active_tab_);
+        if (ImGui::MenuItem("Save All", "Ctrl+Alt+S")) save_all();
         ImGui::Separator();
         // Page Setup — placeholder (requires native print dialog)
         if (ImGui::MenuItem("Page Setup...")) { /* TODO: native dialog */ }
@@ -1012,32 +1016,40 @@ void EditorApp::render_editor_area() {
         new_tab();
     }
 
-    // Tab bar
-    ImGuiTabBarFlags tab_flags = ImGuiTabBarFlags_Reorderable | ImGuiTabBarFlags_AutoSelectNewTabs;
-    if (ImGui::BeginTabBar("##Tabs", tab_flags)) {
-        for (int i = 0; i < (int)tabs_.size(); i++) {
-            auto& tab = tabs_[i];
-            std::string label = tab.display_name;
-            if (tab.dirty) label += " *";
-
-            ImGuiTabItemFlags tab_item_flags = 0;
-            if (i == active_tab_) tab_item_flags |= ImGuiTabItemFlags_SetSelected;
-
-            bool open = true;
-            if (ImGui::BeginTabItem(label.c_str(), &open, tab_item_flags)) {
-                active_tab_ = i;
-                
-                // Render gutter with bookmarks and change history
-                render_editor_with_margins();
-                
-                ImGui::EndTabItem();
-            }
-            if (!open) {
-                close_tab(i);
-                break;
+    // Tab bar - only show if more than one tab
+    bool show_tabs = tabs_.size() > 1;
+    if (show_tabs) {
+        ImGuiTabBarFlags tab_flags = ImGuiTabBarFlags_Reorderable | ImGuiTabBarFlags_AutoSelectNewTabs;
+        if (ImGui::BeginTabBar("##Tabs", tab_flags)) {
+            for (int i = 0; i < (int)tabs_.size(); i++) {
+                auto& tab = tabs_[i];
+                std::string label = tab.display_name;
+                if (tab.dirty) label += " *";
+
+                ImGuiTabItemFlags tab_item_flags = 0;
+                if (i == active_tab_) tab_item_flags |= ImGuiTabItemFlags_SetSelected;
+
+                bool open = true;
+                if (ImGui::BeginTabItem(label.c_str(), &open, tab_item_flags)) {
+                    active_tab_ = i;
+                    
+                    // Render gutter with bookmarks and change history
+                    render_editor_with_margins();
+                    
+                    ImGui::EndTabItem();
+                }
+                if (!open) {
+                    close_tab(i);
+                    break;
+                }
             }
+            ImGui::EndTabBar();
+        }
+    } else {
+        // Single tab - just render the editor directly
+        if (active_tab_ >= 0 && active_tab_ < (int)tabs_.size()) {
+            render_editor_with_margins();
         }
-        ImGui::EndTabBar();
     }
 
     ImGui::End();