optimize integration test case

Author: dk-lockdown

test/rws/read_write_splitting_test.go

@@ -110,6 +110,8 @@ func (suite *_ReadWriteSplittingSuite) TestDelete() {
 		}
 		suite.Equal(0, exists)
 	}
+	err = rows.Close()
+	assert.Nil(suite.T(), err)
 }
 
 func (suite *_ReadWriteSplittingSuite) TestInsert() {
@@ -134,6 +136,8 @@ func (suite *_ReadWriteSplittingSuite) TestInsert() {
 		}
 		suite.Equal("master", firstName)
 	}
+	err = rows.Close()
+	assert.Nil(suite.T(), err)
 }
 
 func (suite *_ReadWriteSplittingSuite) TestSelect1() {
@@ -151,6 +155,8 @@ func (suite *_ReadWriteSplittingSuite) TestSelect1() {
 		}
 		suite.Equal("slave", firstName)
 	}
+	err = rows.Close()
+	assert.Nil(suite.T(), err)
 }
 
 func (suite *_ReadWriteSplittingSuite) TestInsertEncryption() {
@@ -174,6 +180,8 @@ func (suite *_ReadWriteSplittingSuite) TestInsertEncryption() {
 			suite.T().Logf("id: %d, dept name: %s", id, deptName)
 		}
 	}
+	err = rows.Close()
+	assert.Nil(suite.T(), err)
 }
 
 func (suite *_ReadWriteSplittingSuite) TestSelect2() {
@@ -191,6 +199,8 @@ func (suite *_ReadWriteSplittingSuite) TestSelect2() {
 		}
 		suite.Equal("master", firstName)
 	}
+	err = rows.Close()
+	assert.Nil(suite.T(), err)
 }
 
 func (suite *_ReadWriteSplittingSuite) TestUpdate() {
@@ -215,6 +225,8 @@ func (suite *_ReadWriteSplittingSuite) TestUpdate() {
 		}
 		suite.Equal("louis", lastName)
 	}
+	err = rows.Close()
+	assert.Nil(suite.T(), err)
 }
 
 func (suite *_ReadWriteSplittingSuite) TestUpdateEncryption() {
@@ -238,6 +250,8 @@ func (suite *_ReadWriteSplittingSuite) TestUpdateEncryption() {
 			suite.T().Logf("id: %d, dept name: %s", id, deptName)
 		}
 	}
+	err = rows.Close()
+	assert.Nil(suite.T(), err)
 }
 
 func (suite *_ReadWriteSplittingSuite) TestXATransaction() {
@@ -259,7 +273,10 @@ func (suite *_ReadWriteSplittingSuite) TestXATransaction() {
 	assert.Nil(suite.T(), err)
 	_, err = conn.ExecContext(ctx, "XA COMMIT 'abc'")
 	assert.Nil(suite.T(), err)
+	err = conn.Close()
+	assert.Nil(suite.T(), err)
 }
 
 func (suite *_ReadWriteSplittingSuite) TearDownSuite() {
+	suite.db.Close()
 }

test/sdb/crud_test.go

@@ -114,6 +114,8 @@ func (suite *_CRUDSuite) TestInsertEncryption() {
 			suite.T().Logf("id: %d, dept name: %s", id, deptName)
 		}
 	}
+	err = rows.Close()
+	assert.Nil(suite.T(), err)
 }
 
 func (suite *_CRUDSuite) TestSelect() {
@@ -131,6 +133,8 @@ func (suite *_CRUDSuite) TestSelect() {
 		}
 		suite.Equal("scott", firstName)
 	}
+	err = rows.Close()
+	assert.Nil(suite.T(), err)
 }
 
 func (suite *_CRUDSuite) TestUpdate() {
@@ -164,6 +168,8 @@ func (suite *_CRUDSuite) TestUpdateEncryption() {
 			suite.T().Logf("id: %d, dept name: %s", id, deptName)
 		}
 	}
+	err = rows.Close()
+	assert.Nil(suite.T(), err)
 }
 
 func (suite *_CRUDSuite) TestXATransaction() {
@@ -185,6 +191,8 @@ func (suite *_CRUDSuite) TestXATransaction() {
 	assert.Nil(suite.T(), err)
 	_, err = conn.ExecContext(ctx, "XA COMMIT 'abc'")
 	assert.Nil(suite.T(), err)
+	err = conn.Close()
+	assert.Nil(suite.T(), err)
 }
 
 func (suite *_CRUDSuite) TearDownSuite() {
@@ -195,4 +203,5 @@ func (suite *_CRUDSuite) TearDownSuite() {
 			suite.Equal(int64(1), affected)
 		}
 	}
+	suite.db.Close()
 }

test/sdb/distributed_transaction_test.go

@@ -243,6 +243,8 @@ func (suite *_DistributedTransactionSuite) TearDownSuite() {
 	suite.db.Exec(deleteDeptEmpForDT, 1)
 	suite.db.Exec(deleteSalariesForDT, 1)
 	suite.db.Exec(deleteDeptManagerForDT, 1)
-
 	suite.db2.Exec(deleteSalariesForDT, 2)
+
+	suite.db.Close()
+	suite.db2.Close()
 }