Skip to content

Commit 1d88ae2

Browse files
committed
Remove experimental feature entirely
1 parent 4dfac20 commit 1d88ae2

6 files changed

Lines changed: 0 additions & 24 deletions

File tree

doc/Settings.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -394,16 +394,6 @@ This feature enables support for fonts via `winget settings`. The `winget font l
394394
},
395395
```
396396

397-
### sourceEdit
398-
399-
This feature enables support for additional source command improvements via `winget settings`. The `winget source edit` command will become available with this feature.
400-
401-
```json
402-
"experimentalFeatures": {
403-
"sourceEdit": true
404-
},
405-
```
406-
407397
### listDetails
408398

409399
This feature enables support for displaying detailed output from the `list` command. Rather than a table view of the results, when the `--details` option is provided

schemas/JSON/settings/settings.schema.0.2.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -333,11 +333,6 @@
333333
"description": "Enable detailed output option for list command",
334334
"type": "boolean",
335335
"default": false
336-
},
337-
"sourceEdit": {
338-
"description": "Enable source edit command",
339-
"type": "boolean",
340-
"default": false
341336
}
342337
}
343338
}

src/AppInstallerCommonCore/ExperimentalFeature.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ namespace AppInstaller::Settings
4646
return userSettings.Get<Setting::EFFonts>();
4747
case ExperimentalFeature::Feature::ListDetails:
4848
return userSettings.Get<Setting::EFListDetails>();
49-
case ExperimentalFeature::Feature::SourceEdit:
50-
return userSettings.Get<Setting::EFSourceEdit>();
5149
default:
5250
THROW_HR(E_UNEXPECTED);
5351
}
@@ -83,9 +81,6 @@ namespace AppInstaller::Settings
8381
return ExperimentalFeature{ "Font", "fonts", "https://aka.ms/winget-settings", Feature::Font };
8482
case Feature::ListDetails:
8583
return ExperimentalFeature{ "List Details", "listDetails", "https://aka.ms/winget-settings", Feature::ListDetails };
86-
case Feature::SourceEdit:
87-
return ExperimentalFeature{ "Source Editing", "sourceEdit", "https://aka.ms/winget-settings", Feature::SourceEdit };
88-
8984
default:
9085
THROW_HR(E_UNEXPECTED);
9186
}

src/AppInstallerCommonCore/Public/winget/ExperimentalFeature.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ namespace AppInstaller::Settings
2626
Resume = 0x2,
2727
Font = 0x4,
2828
ListDetails = 0x8,
29-
SourceEdit = 0x10,
3029
Max, // This MUST always be after all experimental features
3130

3231
// Features listed after Max will not be shown with the features command

src/AppInstallerCommonCore/Public/winget/UserSettings.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ namespace AppInstaller::Settings
7777
EFResume,
7878
EFFonts,
7979
EFListDetails,
80-
EFSourceEdit,
8180
// Telemetry
8281
TelemetryDisable,
8382
// Install behavior
@@ -166,7 +165,6 @@ namespace AppInstaller::Settings
166165
SETTINGMAPPING_SPECIALIZATION(Setting::EFResume, bool, bool, false, ".experimentalFeatures.resume"sv);
167166
SETTINGMAPPING_SPECIALIZATION(Setting::EFFonts, bool, bool, false, ".experimentalFeatures.fonts"sv);
168167
SETTINGMAPPING_SPECIALIZATION(Setting::EFListDetails, bool, bool, false, ".experimentalFeatures.listDetails"sv);
169-
SETTINGMAPPING_SPECIALIZATION(Setting::EFSourceEdit, bool, bool, false, ".experimentalFeatures.sourceEdit"sv);
170168
// Telemetry
171169
SETTINGMAPPING_SPECIALIZATION(Setting::TelemetryDisable, bool, bool, false, ".telemetry.disable"sv);
172170
// Install behavior

src/AppInstallerCommonCore/UserSettings.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,6 @@ namespace AppInstaller::Settings
268268
WINGET_VALIDATE_PASS_THROUGH(EFResume)
269269
WINGET_VALIDATE_PASS_THROUGH(EFFonts)
270270
WINGET_VALIDATE_PASS_THROUGH(EFListDetails)
271-
WINGET_VALIDATE_PASS_THROUGH(EFSourceEdit)
272271
WINGET_VALIDATE_PASS_THROUGH(AnonymizePathForDisplay)
273272
WINGET_VALIDATE_PASS_THROUGH(TelemetryDisable)
274273
WINGET_VALIDATE_PASS_THROUGH(InteractivityDisable)

0 commit comments

Comments
 (0)