Skip to content

Commit de8c0f3

Browse files
Trenlymdanish-kh
andauthored
Add policy for notifying authors of Localization Restriction (microsoft#6156)
<!-- To check a checkbox place an "x" between the brackets. e.g: [x] --> - [x] I have signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs). - [ ] I have updated the [Release Notes](../doc/ReleaseNotes.md). - [ ] This pull request is related to an issue. ----- ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/6156) --------- Co-authored-by: Muhammad Danish <mdanishkhdev@gmail.com>
1 parent 493657a commit de8c0f3

2 files changed

Lines changed: 43 additions & 0 deletions

File tree

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
name: '🌐 Localization Issue'
2+
description: Report issues in our localization.
3+
type: Task
4+
labels:
5+
- Issue-Localization
6+
- Needs-Triage
7+
body:
8+
- type: textarea
9+
attributes:
10+
label: Brief description of your issue
11+
placeholder: Briefly describe which localization needs to be corrected and why.
12+
validations:
13+
required: true

.github/policies/labelManagement.issueOpened.yml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,36 @@ configuration:
1515
action: Opened
1616
then:
1717
- addCodeFlowLink
18+
- description: Check for modifications of Localization files in new PRs
19+
if:
20+
- payloadType: Pull_Request
21+
- isAction:
22+
action: Opened
23+
- filesMatchPattern:
24+
pattern: Localization/Resources/*
25+
- not:
26+
activitySenderHasPermission: # Only trigger if the sender doesn't have write permissions,
27+
permission: Write # to avoid adding the label for PRs from MSFT intentionally updating these files
28+
then:
29+
- addLabel:
30+
label: Needs-Author-Feedback
31+
- addLabel:
32+
label: Blocking-Issue
33+
- addReply:
34+
reply: >-
35+
Hello ${issueAuthor},
36+
37+
38+
Thank you for your contribution! It looks like your PR includes changes to localization files.
39+
40+
41+
The English resource file [**/en-us/winget.resw](https://github.com/microsoft/winget-cli/blob/master/src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw) is the only file contributors should edit for string changes. It feeds the Microsoft localization pipeline. The files under [Localization\Resources\<locale>\](https://github.com/microsoft/winget-cli/tree/master/Localization/Resources) are **automatically synced from Microsoft's internal localization system and must not be edited**. Any manual edits will be overwritten on the next sync.
42+
43+
44+
Instead of this PR, it would be helpful if you could [open an issue](https://github.com/microsoft/winget-cli/issues/new?template=Localization_Issue.yml) and it will be forwarded to the internal localization team for review. For more information, please see the [Development Guide](https://github.com/microsoft/winget-cli/blob/master/doc/Developing.md#localization).
45+
46+
47+
Template: msftbot/PullRequests/LocalizationFileChange
1848
- description: Add Needs-Triage to new issues
1949
if:
2050
- payloadType: Issues

0 commit comments

Comments
 (0)