Skip to content

Lua: fix SetHandGraphic#4856

Merged
Loobinex merged 2 commits into
dkfans:masterfrom
PieterVdc:fix_lua_Set_hand_graphic
May 30, 2026
Merged

Lua: fix SetHandGraphic#4856
Loobinex merged 2 commits into
dkfans:masterfrom
PieterVdc:fix_lua_Set_hand_graphic

Conversation

@PieterVdc
Copy link
Copy Markdown
Member

also fixes lua_Dead_creatures_return_to_pool

Copilot AI review requested due to automatic review settings May 30, 2026 15:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes two Lua API argument index bugs: Dead_creatures_return_to_pool was reading argument 3 instead of 1, and Set_hand_graphic was reading the hand index from argument 1 (the player) instead of argument 2.

Changes:

  • Correct argument index in lua_Dead_creatures_return_to_pool from 3 to 1.
  • Correct argument index in lua_Set_hand_graphic for hand_idx from 1 to 2.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Loobinex Loobinex merged commit 13f0e56 into dkfans:master May 30, 2026
2 checks passed
@PieterVdc PieterVdc deleted the fix_lua_Set_hand_graphic branch May 30, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants