Skip to content

Commit 7bea32c

Browse files
committed
fix(remove-dep-on-ts-proto): Removes unnecessary ts-proto dependency
1 parent e033120 commit 7bea32c

3 files changed

Lines changed: 9 additions & 12 deletions

File tree

.github/workflows/ci.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ on:
44
name: ci
55
jobs:
66
test:
7-
runs-on: ubuntu-latest
7+
runs-on: ubuntu-22.04
88
strategy:
99
matrix:
10-
node: [20]
10+
node: [18, 20]
1111
include:
1212
# use latest npm by default
13-
- npm-version: latest
13+
- npm-version: 10.9.2
1414
steps:
1515
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
1616
- uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
@@ -19,5 +19,5 @@ jobs:
1919
- run: node --version
2020
- name: Upgrade to latest npm to support lockfile v2
2121
run: npm install -g npm@${{ matrix.npm-version }}
22-
- run: npm install && npm install
23-
- run: npm run test
22+
- run: npm ci --verbose && npm ci --verbose
23+
- run: npm run test

package-lock.json

Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/synthetics-sdk-api/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,10 @@
4040
"@opentelemetry/sdk-node": "0.43.0",
4141
"@opentelemetry/sdk-trace-base": "1.17.0",
4242
"@opentelemetry/sdk-trace-node": "1.17.0",
43+
"axios": "1.6.7",
4344
"error-stack-parser": "2.1.4",
4445
"google-auth-library": "9.0.0",
45-
"ts-proto": "1.148.1",
46-
"winston": "3.10.0",
47-
"axios": "1.6.7"
46+
"winston": "3.10.0"
4847
},
4948
"author": "Google Inc.",
5049
"license": "Apache-2.0"

0 commit comments

Comments
 (0)