Skip to content

Match "32mscoff" to "32" in conditional TEST_OUTPUT#10807

Merged
dlang-bot merged 1 commit intodlang:masterfrom
MoonlightSentinel:mscoff-output
Feb 20, 2020
Merged

Match "32mscoff" to "32" in conditional TEST_OUTPUT#10807
dlang-bot merged 1 commit intodlang:masterfrom
MoonlightSentinel:mscoff-output

Conversation

@MoonlightSentinel
Copy link
Copy Markdown
Contributor

Conditional output for 32 bit compilation seldomly depends on the object format.

For example the generated headers in #10801 don't need to differentiate between -m32 and -m32mscoff

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10807"

Comment thread test/tools/d_do_test.d
Conditional output for 32 bit compilation seldomly depends on the object format
@dlang-bot dlang-bot merged commit 489b81d into dlang:master Feb 20, 2020
@MoonlightSentinel MoonlightSentinel deleted the mscoff-output branch February 20, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants