Mangle C main on Wasm#23303
Conversation
|
Requesting review |
| return; | ||
| } | ||
|
|
||
| version (IN_LLVM) |
There was a problem hiding this comment.
cc @ibuclaw for whatever the GCC logic should be
There was a problem hiding this comment.
DMD has no WASM target, so this changelog entry shouldn't be here
There was a problem hiding this comment.
It can be logged in LDC's release notes, but the changelog in this repo gets published with dmd releases so users are aware of what changed when upgrading dmd.
Newly reserved version WASI identifiers affect dmd because version = WASIp1 is something dmd now rejects. core.stdc updates for WASM could be relevant if anyone used dmd's bundled druntime sources with LDC, but that sounds very niche so I don't think it's worth mentioning. New mangling of WASM main is irrelevant/confusing for dmd users because it is incapable of generating any WASM code. I would delete it indeed.
Mangles
extern(C) mainas__main_voidor__main_argc_argvon Wasm targets, as done by Clang, and expected by thelibcs for Emscripten and WASI.Split from ldc-developers/ldc#5158
Dependent on remainder of said PR to introduce
gen.llvmhelpers.isTargetWasm.