Merge pull request #8773 from FeepingCreature/fix/issue-23976

dkorpel · web-flow · commit 613850c89a0e · 2023-06-23T19:48:20.000+02:00
Fix issue 23976: std.range.slide fails in dmd-2.104.0
diff --git a/std/range/package.d b/std/range/package.d
@@ -9115,7 +9115,7 @@ public:
         {
             static if (needsEndTracker)
             {
-                if (poppedElems < windowSize)
+                if (nextSource.empty)
                     hasShownPartialBefore = true;
             }
             else
@@ -10095,6 +10095,15 @@ public:
     assert("ab cd".splitter(' ').slide!(No.withPartial)(2).equal!equal([["ab", "cd"]]));
 }
 
+// https://issues.dlang.org/show_bug.cgi?id=23976
+@safe unittest
+{
+    import std.algorithm.comparison : equal;
+    import std.algorithm.iteration : splitter;
+
+    assert("1<2".splitter('<').slide(2).equal!equal([["1", "2"]]));
+}
+
 private struct OnlyResult(Values...)
 if (Values.length > 1)
 {

Original file line number	Diff line number	Diff line change
`@@ -9115,7 +9115,7 @@ public:`
`9115`	`9115`	`{`
`9116`	`9116`	`static if (needsEndTracker)`
`9117`	`9117`	`{`
`9118`		`- if (poppedElems < windowSize)`
	`9118`	`+ if (nextSource.empty)`
`9119`	`9119`	`hasShownPartialBefore = true;`
`9120`	`9120`	`}`
`9121`	`9121`	`else`
`@@ -10095,6 +10095,15 @@ public:`
`10095`	`10095`	`assert("ab cd".splitter(' ').slide!(No.withPartial)(2).equal!equal([["ab", "cd"]]));`
`10096`	`10096`	`}`
`10097`	`10097`
	`10098`	`+// https://issues.dlang.org/show_bug.cgi?id=23976`
	`10099`	`+@safe unittest`
	`10100`	`+{`
	`10101`	`+ import std.algorithm.comparison : equal;`
	`10102`	`+ import std.algorithm.iteration : splitter;`
	`10103`	`+`
	`10104`	`+ assert("1<2".splitter('<').slide(2).equal!equal([["1", "2"]]));`
	`10105`	`+}`
	`10106`	`+`
`10098`	`10107`	`private struct OnlyResult(Values...)`
`10099`	`10108`	`if (Values.length > 1)`
`10100`	`10109`	`{`