Fix nthPermutation lexicographic order#10922
Conversation
|
Thanks for your pull request and interest in making D better, @AaritPanda-git! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
10d109a to
d10b99a
Compare
Fix Bugzilla issue 10849
d10b99a to
6fc2129
Compare
|
Gentle ping @PetarKirov in case this slipped through. |
|
Apologies for missing this. Could you rebase to retrigger the CI. |
Fixes #10849
This PR fixes nthPermutation to always produce permutations in
lexicographic order, as implied by the Lehmer code representation
described in the documentation.
When the Lehmer code has leading zeros (idx < range.length),
the previous implementation lost these during reversal, resulting
in incorrect ordering. The fix preserves the leading zeros and
restores correct lexicographic behavior.