Fix #11004: preserve D-style variadics in SetFunctionAttributes#11062
Open
AayushMainali-Github wants to merge 2 commits into
Open
Fix #11004: preserve D-style variadics in SetFunctionAttributes#11062AayushMainali-Github wants to merge 2 commits into
AayushMainali-Github wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
SetFunctionAttributesrebuilt D-style variadic function types by appending"..."afterParameters!Twith no comma. For a function likevoid fn(int a, ...), that producedvoid function(int...)(typesafe variadic) instead ofvoid function(int, ...)(D-style variadic).The mixin now emits
", ..."when there are fixed parameters, and"..."when there are none. Regression coverage was added for D-style variadics with and without fixed parameters, and typesafe variadics are still preserved.Verified locally with
make -f posix.mak BUILD=debug std/traits.test(1 modules passed unittests), and with a direct compile of the issue repro (fails before the fix, passes after).Feature request or issue tracking
Closes #11004.
Pre-review checklist
LLM/AI disclosure
This PR was written with the assistance of an LLM/AI.