Skip to content

Commit 553dfc9

Browse files
committed
Fixed linting errors, removed useless code.
1 parent b6a3429 commit 553dfc9

8 files changed

Lines changed: 15 additions & 44 deletions

File tree

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "berlin-lea-performance-monitor",
3-
"version": "1.11.1",
3+
"version": "1.11.2",
44
"author": "David Leclerc",
55
"main": "./src/index.ts",
66
"scripts": {

src/models/pages/HomePage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { By } from 'selenium-webdriver';
22
import Page from './Page';
33
import logger from '../../logger';
44
import { ConstructionWorkError } from '../errors';
5-
import { MEDIUM_TIME, VERY_VERY_LONG_TIME } from '../../constants/times';
5+
import { VERY_VERY_LONG_TIME } from '../../constants/times';
66
import { HOMEPAGE_URL } from '../../config';
77

88
const TEXTS = {

src/models/pages/ResultsPage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { formatDateForFilename } from '../../utils/locale';
44
import { NoResultsError, FoundNoAppointmentError, NoAppointmentInformationError, GhostUIElementError } from '../errors';
55
import { LogMessage } from '../../constants';
66
import Page from './Page';
7-
import { MEDIUM_TIME, VERY_VERY_LONG_TIME } from '../../constants/times';
7+
import { VERY_VERY_LONG_TIME } from '../../constants/times';
88

99
const TEXTS = {
1010
NoAppointment: 'keine Termine frei',

src/models/scenarios/Scenario.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ abstract class Scenario {
1515
await this.doExecute(bot);
1616

1717
} catch (err: unknown) {
18-
let error = err;
18+
const error = err;
1919

2020
if (err instanceof Error) {
2121
if (isKnownEvent(err.name)) {

src/models/sessions/SessionHistoryBuilder.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ class SessionHistoryBuilder {
3636
const history = new SessionHistory(this.buildBuckets(bucketSize), bucketSize);
3737

3838
let session: IncompleteSession = IncompleteSession.create();
39-
let release: Release = RELEASE_ZERO;
4039

4140
// Read logs in chronological order
4241
logs.forEach(log => {
@@ -45,7 +44,7 @@ class SessionHistoryBuilder {
4544
if (log.msg.includes(TEXTS.SessionStart)) {
4645
session = IncompleteSession.create();
4746

48-
logger.trace(`Starting session: ${session.getId()} [${release.toString()}]`);
47+
logger.trace(`Starting session: ${session.getId()} [${log.version.toJSON()}]`);
4948
session.start(new Date(log.time));
5049
}
5150

@@ -56,7 +55,7 @@ class SessionHistoryBuilder {
5655

5756
// Session ended
5857
if (log.msg.includes(TEXTS.SessionEnd)) {
59-
logger.trace(`Finishing session: ${session.getId()}`);
58+
logger.trace(`Finishing session: ${session.getId()} [${log.version.toJSON()}]`);
6059
session.end(new Date(log.time));
6160

6261
// Sessions should have a start and an end
@@ -75,7 +74,7 @@ class SessionHistoryBuilder {
7574
// Store complete session in history
7675
history.addSession(new CompleteSession({
7776
id: session.getId(),
78-
release,
77+
release: log.version,
7978
startTime: session.getStartTime()!,
8079
endTime: session.getEndTime()!,
8180
logs: session.getLogs(),

src/models/sessions/SessionHistoryExporter.ts

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import logger from '../../logger';
22
import { getLastValue } from '../../utils/array';
3-
import { writeFile, writeJSON } from '../../utils/file';
3+
import { writeFile } from '../../utils/file';
44
import { sum } from '../../utils/math';
55
import { logToText } from '../../utils/parsing';
66
import CompleteSession from './CompleteSession';
@@ -44,17 +44,6 @@ class SessionHistoryExporter {
4444

4545
await writeFile(filepath, lines.join('\n') + '\n');
4646
}
47-
48-
public async exportToJSONFile(filepath: string, history: SessionHistory) {
49-
if (!filepath.endsWith('.json')) {
50-
const ext = getLastValue(filepath.split('.'));
51-
throw new Error(`Invalid file extension for export: ${ext}`);
52-
}
53-
54-
const data: any = [];
55-
56-
await writeJSON(filepath, data);
57-
}
5847
}
5948

6049
export default SessionHistoryExporter.getInstance();

src/utils/parsing.ts

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import logger from '../logger';
33
import Release from '../models/Release';
44
import { Log } from '../types';
55
import { listFiles, readFile } from './file';
6-
import fs from 'fs';
76

87

98

@@ -44,9 +43,9 @@ export const parseLogs = async (filepath: string, since?: Date | Release) => {
4443

4544
if (since) {
4645
if (since instanceof Date) {
47-
logger.info(`Keeping logs newer than: ${since}`);
46+
logger.debug(`Keeping logs newer than: ${since}`);
4847
} else {
49-
logger.info(`Keeping logs with release version higher or equal to: ${since.toString()}`);
48+
logger.debug(`Keeping logs with release version higher or equal to: ${since.toString()}`);
5049
}
5150
}
5251

@@ -67,25 +66,9 @@ export const parseLogs = async (filepath: string, since?: Date | Release) => {
6766
})
6867
.filter(hasLogMessage); // Every log should have a message
6968

70-
logger.debug(`Parsed ${logs.length} valid log entries.`);
71-
72-
return logs;
73-
}
74-
75-
76-
77-
export const findAndParseLogs = async (dir: string, since?: Date | Release) => {
78-
logger.info(`Finding and reading logs...`);
79-
80-
if (since) {
81-
if (since instanceof Date) {
82-
logger.info(`Keeping logs newer than: ${since}`);
83-
} else {
84-
logger.info(`Keeping logs with release version higher or equal to: ${since.toString()}`);
85-
}
69+
if (logs.length > 0) {
70+
logger.debug(`Parsed ${logs.length} valid log entries.`);
8671
}
8772

88-
const files = await listFiles(dir);
89-
90-
console.log(files);
73+
return logs;
9174
}

0 commit comments

Comments
 (0)