Revert "Adding Processor Registry to provision Atomic swapping of Processor instances (opensearch-project#5794)"

This reverts commit 844eac1

Signed-off-by: David Venable <dlv@amazon.com>

Author: dlvenable

data-prepper-core/src/integrationTest/java/org/opensearch/dataprepper/integration/PipelinesWithAcksIT.java

@@ -27,7 +27,6 @@
 import static org.hamcrest.Matchers.empty;
 import static org.hamcrest.Matchers.lessThanOrEqualTo;
 import static org.junit.Assert.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 @FixMethodOrder()
@@ -53,15 +52,15 @@ void setUp(String configFile) {
                 .withPipelinesDirectoryOrFile(configFile)
                 .build();
 
-        LOG.info("PipelinesWithAcksIT with config file {} started at {}", configFile, Instant.now());
+	LOG.info("PipelinesWithAcksIT with config file {} started at {}", configFile, Instant.now());
         dataPrepperTestRunner.start();
         inMemorySourceAccessor = dataPrepperTestRunner.getInMemorySourceAccessor();
         inMemorySinkAccessor = dataPrepperTestRunner.getInMemorySinkAccessor();
     }
 
     @AfterEach
     void tearDown() {
-        LOG.info("PipelinesWithAcksIT with stopped at {}", Instant.now());
+	LOG.info("PipelinesWithAcksIT with stopped at {}", Instant.now());
         dataPrepperTestRunner.stop();
     }
 
@@ -134,8 +133,8 @@ void three_pipelines_with_all_unrouted_records() {
 
         await().atMost(40000, TimeUnit.MILLISECONDS)
                 .untilAsserted(() -> {
-                    assertNotNull(inMemorySourceAccessor);
-                    assertNotNull(inMemorySourceAccessor.getAckReceived());
+            assertTrue(inMemorySourceAccessor != null);
+            assertTrue(inMemorySourceAccessor.getAckReceived() != null);
         });
         List<Record<Event>> outputRecords = inMemorySinkAccessor.get(IN_MEMORY_IDENTIFIER);
         assertThat(outputRecords.size(), equalTo(0));

data-prepper-core/src/integrationTest/java/org/opensearch/dataprepper/integration/ProcessorSwapPipelineIT.java

@@ -8,16 +8,13 @@
 import org.opensearch.dataprepper.AbstractContextManager;
 import org.opensearch.dataprepper.core.DataPrepper;
 import org.opensearch.dataprepper.core.parser.config.FileStructurePathProvider;
-import org.opensearch.dataprepper.model.plugin.PluginFactory;
-import org.opensearch.dataprepper.model.processor.Processor;
 import org.opensearch.dataprepper.plugins.InMemorySinkAccessor;
 import org.opensearch.dataprepper.plugins.InMemorySourceAccessor;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.context.annotation.AnnotationConfigApplicationContext;
 
 import javax.annotation.Nullable;
-import java.util.List;
 
 /**
  * Provides the ability to run a Data Prepper test instance. Each of these will run
@@ -28,7 +25,7 @@
  */
 public class DataPrepperTestRunner {
     private static final Logger LOG = LoggerFactory.getLogger(DataPrepperTestRunner.class);
-    public static final String BASE_PATH = "src/integrationTest/resources/org/opensearch/dataprepper";
+    private static final String BASE_PATH = "src/integrationTest/resources/org/opensearch/dataprepper";
     private final String dataPrepperConfigFile;
     private final String pipelinesDirectoryOrFile;
     private final InMemorySourceAccessor inMemorySourceAccessor;
@@ -63,20 +60,6 @@ public void start() {
                 .execute();
     }
 
-    public PluginFactory getPluginFactory() {
-        return contextManager.getDataPrepperBean()
-                .getPluginFactory();
-    }
-
-    /**
-     * Dynamically Swap processors in a running pipeline
-     */
-    public void swapProcessors(String pipelineName, List<Processor> newProcessors) {
-        contextManager.getDataPrepperBean()
-                .getPipeline(pipelineName)
-                .swapProcessors(newProcessors);
-    }
-
     /**
      * Stops the Data Prepper test instance.
      */

data-prepper-core/src/integrationTest/java/org/opensearch/dataprepper/test/framework/DataPrepperTestRunner.java

@@ -102,10 +102,6 @@ public void shutdown() {
         shutdownServers();
     }
 
-    public Pipeline getPipeline(String pipelineName) {
-        return transformationPipelines.get(pipelineName);
-    }
-
     private void shutdownPipelines() {
         shutdownPipelines(DataPrepperShutdownOptions.defaultOptions());
     }

data-prepper-core/src/integrationTest/resources/org/opensearch/dataprepper/pipeline/processor-swap/source/processor-swap-pipeline.yaml

@@ -74,7 +74,7 @@ public class PipelineTransformer {
 
     private final ExpressionEvaluator expressionEvaluator;
 
-    public PipelineTransformer(
+    public PipelineTransformer(final PipelinesDataFlowModel pipelinesDataFlowModel,
                                final PluginFactory pluginFactory,
                                final PeerForwarderProvider peerForwarderProvider,
                                final RouterFactory routerFactory,