Skip to content

Commit b9ad8bb

Browse files
frags51supsing
authored andcommitted
[playwright-browser-tunnel] Fix launch option for playwright tunnel (microsoft#5688)
* correct launch option * rush change * ext version bump --------- Co-authored-by: supsing <supsing_microsoft@users.noreply.github.com>
1 parent d7b016c commit b9ad8bb

3 files changed

Lines changed: 13 additions & 2 deletions

File tree

apps/playwright-browser-tunnel/src/tunneledBrowserConnection/TunneledBrowserConnection.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,8 @@ export async function tunneledBrowserConnection(
156156
if (bName && SUPPORTED_BROWSER_NAMES.has(bName)) {
157157
browserName = bName as BrowserName;
158158
}
159-
const launchOptionsParam: string | null = parsed.searchParams.get('launchOptions');
159+
const launchOptionsParam: string | null =
160+
parsed.searchParams.get('launch-options') || parsed.searchParams.get('launchOptions');
160161
if (launchOptionsParam) {
161162
try {
162163
launchOptions = JSON.parse(launchOptionsParam);
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@rushstack/playwright-browser-tunnel",
5+
"comment": "Fix the launch-options param",
6+
"type": "patch"
7+
}
8+
],
9+
"packageName": "@rushstack/playwright-browser-tunnel"
10+
}

vscode-extensions/playwright-local-browser-server-vscode-extension/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "playwright-local-browser-server",
3-
"version": "0.1.3",
3+
"version": "0.1.4",
44
"repository": {
55
"type": "git",
66
"url": "https://github.com/microsoft/rushstack.git",

0 commit comments

Comments
 (0)