Fixed UI lags when resizing the window

Author: dmitry-s93

CHANGELOG.md

@@ -3,6 +3,7 @@
 All notable changes to this project will be documented in this file.
 
 ## Unreleased
+- Fixed UI lags when resizing the window (issue https://github.com/dmitry-s93/MControlCenter/issues/97)
 - Updated Norwegian Bokmål (Thanks [msigurdsen](https://github.com/msigurdsen))
 - Added support for German language (Thanks [EchterAlsFake](https://github.com/EchterAlsFake))
 - Added support for Hungarian language (Thanks [BiRo96](https://github.com/BiRo96))

src/helper.cpp

@@ -18,6 +18,7 @@
 
 #include "helper/service.h"
 #include "helper.h"
+#include "mainwindow.h"
 
 #include <QCoreApplication>
 #include <QDBusReply>
@@ -60,6 +61,25 @@ bool Helper::updateData() {
     return false;
 }
 
+void Helper::updateDataAsync() {
+    QDBusPendingCall async = iface->asyncCall("getData");
+    QDBusPendingCallWatcher const *watcher = new QDBusPendingCallWatcher(async, this);
+
+    QObject::connect(watcher, SIGNAL(finished(QDBusPendingCallWatcher*)),this, SLOT(callFinishedSlot(QDBusPendingCallWatcher*)));
+}
+
+void Helper::callFinishedSlot(QDBusPendingCallWatcher *call) {
+    QDBusPendingReply<QByteArray> reply = *call;
+    if (reply.isError()) {
+        printError(reply.error());
+        MainWindow::setUpdateDataError(true);
+    } else {
+        ecData = reply.value();
+        MainWindow::setUpdateDataError(false);
+    }
+    call->deleteLater();
+}
+
 int Helper::getValue(int address) const {
     if (!ecData.isEmpty())
         return (BYTE) ecData[address];

src/helper.h

@@ -32,13 +32,16 @@ Q_OBJECT
     bool isEcSysModuleLoaded();
     bool loadEcSysModule();
     bool updateData();
+    void updateDataAsync();
     int getValue(int address) const;
     QByteArray getValues(int startAddress, int size) const;
     void putValue(int address, int value);
     void quit();
     QDBusInterface *iface;
 private:
     void printError(QDBusError const & error) const;
+private slots:
+    void callFinishedSlot(QDBusPendingCallWatcher *call);
 };
 
 #endif // HELPER_H

src/mainwindow.cpp

@@ -26,6 +26,7 @@
 Operate operate;
 
 bool isActive = false;
+bool isUpdateDataError = false;
 
 QTimer *realtimeUpdateTimer = new QTimer;
 
@@ -152,7 +153,8 @@ MainWindow::MainWindow(QWidget *parent)
     if (!operate.isEcSysModuleLoaded() && !operate.loadEcSysModule())
         QMessageBox::critical(nullptr, this->windowTitle(), tr("Failed to load the ec_sys kernel module"));
 
-    updateData();
+    if(operate.updateEcData())
+        updateData();
 
     connect(realtimeUpdateTimer, &QTimer::timeout, this, &MainWindow::realtimeUpdate);
     setUpdateInterval(1000);
@@ -162,6 +164,10 @@ MainWindow::~MainWindow() {
     delete ui;
 }
 
+void MainWindow::setUpdateDataError(bool error) {
+    isUpdateDataError = error;
+}
+
 void MainWindow::setTabsEnabled(bool enabled) {
     ui->infoTab->setEnabled(enabled);
     ui->modeTab->setEnabled(enabled);
@@ -189,11 +195,12 @@ void MainWindow::setUpdateInterval(int msec) const {
 }
 
 void MainWindow::realtimeUpdate() {
+    operate.updateEcDataAsync();
     updateData();
 }
 
 void MainWindow::updateData() {
-    if (operate.updateEcData()) {
+    if (!isUpdateDataError && !operate.getEcVersion().empty()) {
         if (!isActive) {
             operate.doProbe();
             setTabsEnabled(true);

src/mainwindow.h

@@ -23,6 +23,7 @@
 #include <QCloseEvent>
 #include <QSystemTrayIcon>
 #include <QtWidgets>
+#include <QDBusPendingCallWatcher>
 
 QT_BEGIN_NAMESPACE
 namespace Ui { class MainWindow; }
@@ -34,6 +35,8 @@ Q_OBJECT
 public:
     explicit MainWindow(QWidget *parent = nullptr);
     ~MainWindow();
+    void updateData();
+    static void setUpdateDataError(bool error);
 
 private:
     Ui::MainWindow *ui;
@@ -43,7 +46,6 @@ Q_OBJECT
     void stopRealtimeUpdate() const;
     void setUpdateInterval(int msec) const;
     void realtimeUpdate();
-    void updateData();
     void loadConfigs();
 
     [[nodiscard]] QString intToQString(int value) const;

src/operate.cpp

@@ -105,6 +105,10 @@ bool Operate::updateEcData() const {
     return helper.updateData();
 }
 
+void Operate::updateEcDataAsync() const {
+    helper.updateDataAsync();
+}
+
 bool Operate::doProbe() const {
     fan1Address = detectFan1Address();
     batteryThresholdAddress = detectBatteryThresholdAddress();

src/operate.h

@@ -55,6 +55,7 @@ class Operate {
     [[nodiscard]] bool isEcSysModuleLoaded() const;
     [[nodiscard]] bool loadEcSysModule() const;
     [[nodiscard]] bool updateEcData() const;
+    void updateEcDataAsync() const;
     [[nodiscard]] bool doProbe() const;
     [[nodiscard]] std::string getEcVersion() const;
     [[nodiscard]] std::string getEcBuild() const;