add: support for symbolic icon#318
Open
ferdiu wants to merge 2 commits into
Open
Conversation
Signed-off-by: ferdiu <ferdiu.manzella@gmail.com>
Signed-off-by: ferdiu <ferdiu.manzella@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abouttab because it is not relevant in any other tab, but it wasn't worth adding an entire new tab just for this setting)pngicon has been removed and thesvgone is now used directly as a compiled resource in the final executable (stripped executable went from 620KB to 487KB at no cost; not a game changer but its ~21% less)It might seem like a minor change, but for me—and I imagine for others too—seeing colors in that corner of the screen means "new notification".
The icon colors are the ones used by the default KDE Plasma theme (breeze). The Italian translation is following the terms used in the KDE Plasma Italian translation from system settings application.
For future reference: it might be more robust to use
QIcon::fromThememethod to reference icons. This way custom themes can be able to override the icons to match the style.