Skip to content

Commit ee07ab6

Browse files
committed
Link Spark issue for overwrite bug
1 parent 1c28233 commit ee07ab6

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

tests/test_distributed/test_with_spark/test_spark_local.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -997,7 +997,7 @@ def test_gpu_transform(self, clf_data: ClfData, spark: SparkSession) -> None:
997997
with tempfile.TemporaryDirectory() as tmpdir:
998998
path = "file:" + tmpdir
999999
# PySpark Connect ML does not support overwrite - this is a bug in Spark:
1000-
# https://github.com/apache/spark/blob/v4.1.1/python/pyspark/ml/util.py#L574-L579
1000+
# https://issues.apache.org/jira/browse/SPARK-55452
10011001
if "pyspark.sql.connect" in type(spark).__module__:
10021002
model.write().save(path)
10031003
else:
@@ -1878,7 +1878,7 @@ def check_conf(conf: Config) -> None:
18781878
check_conf(classifier.getOrDefault(classifier.coll_cfg))
18791879

18801880
# PySpark Connect ML does not support overwrite - this is a bug in Spark:
1881-
# https://github.com/apache/spark/blob/v4.1.1/python/pyspark/ml/util.py#L574-L579
1881+
# https://issues.apache.org/jira/browse/SPARK-55452
18821882
if self.mode == "connect":
18831883
classifier.write().save(path)
18841884
else:
@@ -1891,10 +1891,10 @@ def check_conf(conf: Config) -> None:
18911891
check_conf(model.getOrDefault(model.coll_cfg))
18921892

18931893
# PySpark ML Connect does not support overwrite - this is a bug in Spark:
1894-
# https://github.com/apache/spark/blob/v4.1.1/python/pyspark/ml/util.py#L574-L579
1894+
# https://issues.apache.org/jira/browse/SPARK-55452
18951895
if self.mode == "connect":
1896-
import shutil
1897-
shutil.rmtree(tmpdir + "/metadata")
1896+
# import shutil
1897+
# shutil.rmtree(tmpdir + "/metadata")
18981898
model.write().save(path)
18991899
else:
19001900
model.write().overwrite().save(path)

0 commit comments

Comments
 (0)