Remove the use of gpu_id in cpp tests.#11539
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the use of the obsolete "gpu_id" parameter from cpp tests and replaces it with the new "device" parameter. Key changes include:
- Updating test configurations to replace "gpu_id" with "device" and adjusting corresponding logic and JSON comparisons.
- Revising GPU-related tests in serialization, learner, context, predictor, objective, and GBTree files to ensure consistency in GPU device handling.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/cpp/test_serialization.cc | Replaced gpu_id checks with device parameter and updated JSON tests. |
| tests/cpp/test_learner.cc | Modified learner parameter setups to use device instead of gpu_id. |
| tests/cpp/test_context.cu | Updated context configuration and thread test cases to use device. |
| tests/cpp/predictor/test_predictor.cc | Replaced gpu_hist/gpu_id settings with a consistent device configuration. |
| tests/cpp/objective/test_objective.cc | Updated objective test configuration to use device parameter. |
| tests/cpp/gbm/test_gbtree.cc | Modified GBTree tests to replace deprecated gpu_id usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.