Skip to content

Update pre-commit clang format to latest.#11980

Merged
trivialfis merged 3 commits into
dmlc:masterfrom
trivialfis:update-pre-commit
Jan 31, 2026
Merged

Update pre-commit clang format to latest.#11980
trivialfis merged 3 commits into
dmlc:masterfrom
trivialfis:update-pre-commit

Conversation

@trivialfis

@trivialfis trivialfis commented Jan 30, 2026

Copy link
Copy Markdown
Member

https://github.com/pre-commit/mirrors-clang-format/tags

  • Update clang format
  • Disable formatting code comments

The old clang format doesn't recognize // clang-format off comment. I would like to be able to keep some blocks from being formatted.

The formatting for code comments is quite off. Comments are usually intentionally formatted in a way that's easy to read, like this table. It's better to not let clang-format change it.

@trivialfis
trivialfis requested a review from RAMitchell January 30, 2026 20:42
@trivialfis

Copy link
Copy Markdown
Member Author

cc @RAMitchell @hcho3

@trivialfis
trivialfis merged commit ac4fe0d into dmlc:master Jan 31, 2026
76 checks passed
@trivialfis
trivialfis deleted the update-pre-commit branch January 31, 2026 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants