Make linux packaging easier#12055
Merged
Merged
Conversation
bkmgit
commented
Mar 2, 2026
bkmgit
commented
Contributor
- Enable use of system dmlc see https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
- Add soname to shared library see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries
- Enable use of system dmlc - Add soname to shared library
Member
|
I understand that distributions frown upon submodules, but the coupling between XGBoost and dmlc core is tie at the moment. We bump dmlc to fix issues there. Are you quite sure using a system one is desirable? |
Contributor
Author
|
Yes, this is ok. Both can be upgraded at the same time. |
Member
|
I will wait for @hcho3 with the dmlc PR. |
trivialfis
reviewed
Mar 3, 2026
| add_library(xgboost STATIC) | ||
| else() | ||
| add_library(xgboost SHARED) | ||
| set_target_properties(xgboost PROPERTIES |
Collaborator
There was a problem hiding this comment.
This adds versioning to *.so files. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries
| xgboost_target_link_libraries(${target}) | ||
| xgboost_target_defs(${target}) | ||
| endforeach() | ||
| if(NOT BUILD_WTIH_DMLC_SYSTEM) |
Member
There was a problem hiding this comment.
Why is this needed, what's changed?
Contributor
Author
There was a problem hiding this comment.
DMLC does not need to be built and installed if it is already on the system and the system version is used.
trivialfis
approved these changes
Mar 9, 2026
Member
|
The GHA test is being throttled by GH? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.