Unify CI configure workflow#12170
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes the repeated “ci-configure” logic (ECR login + CI image tag selection) into a reusable GitHub Actions workflow and updates existing CI workflows to call it, keeping downstream needs.ci-configure.outputs.* references stable.
Changes:
- Added reusable workflow
.github/workflows/ci_configure.ymlexposing the same outputs as the prior duplicated jobs. - Updated
main.yml,jvm_tests.yml, andmisc.ymlto replace inlineci-configurejob steps with auses:call to the reusable workflow. - Parameterized the runner tag via
tag-prefixto preserve per-workflow runner tagging.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/ci_configure.yml | Introduces reusable workflow_call implementation for ECR login + image tag resolution and exposes outputs. |
| .github/workflows/main.yml | Replaces duplicated ci-configure job with a call to the reusable workflow (tag-prefix main). |
| .github/workflows/jvm_tests.yml | Replaces duplicated ci-configure job with a call to the reusable workflow (tag-prefix jvm-tests). |
| .github/workflows/misc.yml | Replaces duplicated ci-configure job with a call to the reusable workflow (tag-prefix misc). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hcho3
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci_configure.ymlworkflow for ECR login and CI image tag resolution.ci-configurejobs inmain.yml,jvm_tests.yml, andmisc.ymlwith calls to the reusable workflow.needs.ci-configure.outputs.*references do not change.Rationale
The configure job still needs to run before containerized jobs because GitHub Actions resolves
container.imageandcontainer.credentialsbefore job steps execute. This change keeps that staging model, but removes the copied implementation from each workflow.python_wheels_variants.ymlstill has a separate ECR login job because it uses a differentecr-loginpattern and image tag flow.Testing
git diff --checkpre-commit run --files .github/workflows/ci_configure.yml .github/workflows/main.yml .github/workflows/jvm_tests.yml .github/workflows/misc.ymlneeds.ci-configure.outputs.*