Document clang-tidy flow and drop legacy CI job#12175
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates XGBoost contributor documentation and CI to standardize on the clang-generated CUDA compile database flow for clang-tidy, removing the legacy CI job that ran the older wrapper.
Changes:
- Document
ops/pipeline/run-clang-tidy-clang-cuda.shas the recommended localclang-tidyentry point, including scoping via env vars and CLI flags. - Remove the legacy
clang-tidyCI job and keep the compile-database-based job as the canonical workflow path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
doc/contrib/coding_guide.rst |
Replaces local clang-tidy instructions with the clang-CUDA compile DB helper and adds usage examples/configuration knobs. |
.github/workflows/lint.yml |
Drops the legacy clang-tidy CI job and retains the compile DB clang-tidy job under the clang-tidy job key. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trivialfis
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the contributor documentation to use the clang-CUDA compile-database clang-tidy flow and remove the legacy CI job that still ran the old wrapper script.
What changed
ops/pipeline/run-clang-tidy-clang-cuda.shas the local clang-tidy entry pointXGBOOST_TIDY_FILES,XGBOOST_TIDY_CHECKS, and helper argumentsclang-tidyjobTesting
pre-commit run --files .github/workflows/lint.yml doc/contrib/coding_guide.rst