fix: align verbose default in XGBRanker.fit() with other estimators#12184
Merged
Conversation
twdavisx
force-pushed
the
fix/xgbranker-verbose-default
branch
from
April 26, 2026 20:41
f36b3a9 to
ca13ed7
Compare
trivialfis
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XGBRanker.fit()hadverbose=Falseas its default whileXGBModel,XGBClassifier, andXGBRegressorall default toverbose=True. Thiscaused inconsistent behavior when
eval_setwas provided — XGBRankerwould silently suppress evaluation output while all other estimators
printed it by default.
Changed
verbosedefault inXGBRanker.fit()fromFalsetoTrueto match the rest of the sklearn API.
Added test_verbose_default_consistency to verify that verbose defaults to the same value across all sklearn estimators
Addresses #12183