Use context for thrust caching policy.#12191
Merged
Merged
Conversation
Replace all existing use of the free function.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GPU-side Thrust usage to rely on the CUDA Context/CUDAContext for the caching execution policy (instead of a free helper), ensuring Thrust operations consistently use the context’s allocator and stream.
Changes:
- Remove the
dh::CachingThrustPolicy()free function fromdevice_helpers.cuh. - Update
FeatureInteractionConstraintDevice::Splitto accept aContextand usectx->CUDACtx()->CTP()for the Thrust fill. - Update call sites (GPU hist updater + CUDA tests) to pass a CUDA context and use
CTP()where needed.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/cpp/tree/test_constraints.cu | Create CUDA context in GPU constraint tests and pass it into Split/QueryNode; minor formatting cleanups. |
| tests/cpp/common/test_device_vector.cu | Use ctx.CUDACtx()->CTP() for Thrust algorithms in tests; add required includes/helpers. |
| src/tree/updater_gpu_hist.cu | Pass ctx_ into interaction-constraint Split during tree expansion. |
| src/tree/constraints.cুহ | Update FeatureInteractionConstraintDevice::Split signature to accept Context const*. |
| src/tree/constraints.cu | Use ctx->CUDACtx()->CTP() for the buffer clear after split. |
| src/common/device_helpers.cuh | Remove CachingThrustPolicy() helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RAMitchell
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all existing use of the free function.