Conversation
hcho3
changed the title
Member
|
Could you please share the motivation of doing this? |
Contributor
|
@trivialfis Scikit-Build-Core is the reference build backend for CMake. It's significantly more robust & tested than using custom sauce while providing future proofing of the build system. |
Collaborator
Author
|
TODO. Test the wheel to ensure that it is compatible with multiple Python and CUDA versions. |
Contributor
|
I just noticed this PR, @hcho3 @trivialfis let me know any time if you want me to review or have questions. We've been using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the Python build backend to scikit-build-core.
Substantial portion of the changes was generated by Claude Code. I personally reviewed the changes.
Special thanks to @DEKHTIARJonathan for guidance.