Update types for CTK 13.3

[jakirkham]

Fixes #12229

CUDA 13.3 builds fail due to...

• Missing template from emplace method call
• Issue deducing decltype of member value (inlined result)

[jakirkham]

IIUC new_enc is defined as DeviceColumnsView

xgboost/src/encoder/ordinal.cuh

Line 226 in a6d7c33

Span<std::int32_t const> sorted_idx, DeviceColumnsView new_enc,

DeviceColumnsView is just shorthand for ColumnsViewImpl<DeviceCatIndexView>

xgboost/src/encoder/ordinal.h

Line 162 in a6d7c33

using DeviceColumnsView = detail::ColumnsViewImpl<DeviceCatIndexView>;

When looking at ColumnsViewImpl<DeviceCatIndexView>, it defines feature_segments as std::int32_t const. Think the const being passed to std::vector is what is causing the compilation error

xgboost/src/encoder/ordinal.h

Lines 124 to 131 in a6d7c33

	template <typename Variant>
	struct ColumnsViewImpl {
	using VariantT = Variant;
	Span<Variant const> columns;
	// Segment pointer for features, each segment represents the number of categories in a feature.
	Span<std::int32_t const> feature_segments;

Am curious, how is const being used here?

Edit: Providing more context on how I'm reading the code

[bdice]

You could also try std::decay_t if you want to keep decltype and avoid hardcoding the type.

[jakirkham]

IIUC the value_type is trying to remove const here:

xgboost/include/xgboost/span.h

Lines 435 to 438 in a6d7c33

	class Span {
	public:
	using element_type = T; // NOLINT
	using value_type = typename std::remove_cv<T>::type; // NOLINT

Though that doesn't seem to be reflected in the compiler error we get.

[jakirkham]

Only C++ code was changed. So the Python lint issues should be unrelated.

Recently scikit-learn released 1.9.0, so an upstream change may explain the Python test failure.

In any case, these appear to be unrelated failures.

[trivialfis]

Created a pr here: #12232

I think it's a bug in the compiler.

[jakirkham]

Thanks Jiaming! 🙏

We still need these template lines too. Could you please add them in your PR?

[trivialfis]

Let me know if you want me to merge or you have more pending changes in mind.

[jakirkham]

Thanks Jiaming! 🙏

These changes look reasonable to me. Nothing further to add.

Please feel free to merge when you are ready.