Fix compilation with ctk133.#12232
Closed
trivialfis wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CUDA Toolkit 13.3 compilation issues in the categorical ordinal encoder by avoiding problematic type deduction patterns seen with newer NVCC/CCCL toolchains.
Changes:
- Introduce a
SegIdxTalias indetail::ColumnsViewImpland use it forfeature_segments’ element type. - Replace a
decltype(new_enc.feature_segments)::value_typehost-side vector declaration with the new stable alias (decltype(new_enc)::SegIdxT) in the missing-category reporting path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/encoder/ordinal.h | Adds SegIdxT alias and uses it to type feature_segments consistently. |
| src/encoder/ordinal.cuh | Uses SegIdxT for the host mirror of feature_segments, avoiding NVCC template/type deduction failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
that's new. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #12229
close #12225