Support VS2026.#12245
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates build tooling to recognize Visual Studio 2026 CMake generators, simplifies parts of the Dask integration by assuming newer Dask worker APIs, and refactors the JVM JNI build script (create_jni.py) to use more modern Python patterns and avoid shell-string subprocess calls.
Changes:
- Add Visual Studio 2026 as a supported CMake generator on Windows for native library builds.
- Update Dask thread detection to use
worker.state.nthreads(dropping older worker APIs). - Refactor
jvm-packages/create_jni.pyto usepathlib, structured subprocess invocation, and clearer build/copy helpers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python-package/xgboost/dask/utils.py | Assumes newer Dask worker API (worker.state.nthreads) for thread detection. |
| python-package/packager/nativelib.py | Adds -GVisual Studio 18 2026 to the Windows generator fallback list. |
| jvm-packages/create_jni.py | Refactors JNI build script and adds VS2026 generator attempts; restructures build/copy logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Merging to unblock the CI. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the VS2026 CMake generator, this patch drops support for older dask versions, reworks create_jni.py to handle pylint errors, and uses newer Python features as a drive-by cleanup.
close #11805