Support coherent memory for inplace predict.#12268
Draft
trivialfis wants to merge 3 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to enable “coherent memory” scenarios for inplace prediction, where the booster runs on CUDA while the input data remains on the host, by relaxing the device-mismatch handling and adding a CUDA runtime helper to detect coherent-memory capability.
Changes:
- Add
curt::IsCoherentMemory(device)CUDA runtime helper and expose it incuda_rt_utils.h. - Update
GBTree::InplacePredictto allow bypassing mismatched-device handling when host memory is coherent and the booster is on CUDA.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/gbm/gbtree.cc |
Adds coherent-memory check to relax device mismatch handling in InplacePredict. |
src/common/cuda_rt_utils.h |
Declares new curt::IsCoherentMemory helper. |
src/common/cuda_rt_utils.cc |
Implements curt::IsCoherentMemory using CUDA device properties. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trivialfis
force-pushed
the
cuda-integrated
branch
from
July 6, 2026 08:37
46bc60f to
60b9471
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support running inplace predict with GPU directly on CPU inputs.