Unintuitive: $VARLOCK_IS_CI is not boolean

[bestickley]

Not sure whether to make this an issue, so let's start with discussion.

Key issue: $VARLOCK_IS_CI return string, not a boolean. I'd expect a boolean.

Confusing examples when run locally:

MY_VAR=not($VARLOCK_IS_CI) results in

✅ MY_VAR*
   └ false

I'd expect true.

Workaround:

MY_VAR=eq($VARLOCK_IS_CI, "false") results in:

✅ MY_VAR*
   └ true

which is fine but more verbose than I'd prefer.

Changing $VARLOCK_IS_CI to be boolean is breaking change, so maybe wait until 1.0.0 for this if you agree with me.

[philmillman]

Yeah as noted in the docs it's a string (https://varlock.dev/reference/builtin-variables/#varlock_is_ci). I'm assuming this was to preserve compat in process.env or because this value is pre-coercion, but @theoephraim will know best.

[theoephraim]

Oh I think that’s just a bug!

[philmillman]

varlock/packages/varlock/src/env-graph/lib/builtin-vars.ts

Line 68 in 349d517

resolver: (ciEnv) => (ciEnv.isCI ? 'true' : 'false'),

[theoephraim]

The fix for it being a string instead of a boolean will be rolled out this afternoon!