Skip to content

fix: fall back to git rev-parse in find_in_git_root#337

Open
kuishou68 wants to merge 1 commit intodmtrKovalenko:mainfrom
kuishou68:cocoon/triage-next-pr
Open

fix: fall back to git rev-parse in find_in_git_root#337
kuishou68 wants to merge 1 commit intodmtrKovalenko:mainfrom
kuishou68:cocoon/triage-next-pr

Conversation

@kuishou68
Copy link
Copy Markdown

Summary

  • wait briefly for the initial scan before reading the cached git root
  • fall back to git rev-parse --show-toplevel when the cached git root is still unavailable
  • add regression tests covering the startup-race fallback and the no-repo warning path

Notes

  • I couldn't run the Neovim/Rust test stack in this sandbox because nvim and cargo are unavailable here.
  • The patch is intentionally small and only changes find_in_git_root() plus focused Lua tests.

Closes #233

@dmtrKovalenko
Copy link
Copy Markdown
Owner

I have deprecated find in git root because the current find automatically does that right? Or not? I’m really unsure what your expected behavior here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Not in a git repo" returns

2 participants