fix: coerce Blob values to string in format_file_display#342
Merged
dmtrKovalenko merged 1 commit intodmtrKovalenko:mainfrom Apr 6, 2026
Merged
Conversation
vim.json.decode returns Blobs instead of strings when the decoded value contains NUL bytes. Passing a Blob to strdisplaywidth triggers E976. Guard item.name and item.directory the same way grep_renderer.lua already guards line_content. Fixes dmtrKovalenko#310
Owner
|
Thank you! I once started working on the fix but then got interested why some items contain NUL and never delivered 😭😭😭 Do you know by any chance? |
Contributor
Author
I don't! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vim.json.decodereturns Blobs instead of strings when the decoded value contains NUL bytes. Informat_file_display,item.nameanditem.directoryflow straight intostrdisplaywidthwhich triggers E976.Added the same type guard that
grep_renderer.luaalready uses forline_content.Fixes #310