fix(parser): accept "git" alias in negated git-status#397
Merged
dmtrKovalenko merged 1 commit intodmtrKovalenko:mainfrom Apr 20, 2026
Merged
fix(parser): accept "git" alias in negated git-status#397dmtrKovalenko merged 1 commit intodmtrKovalenko:mainfrom
dmtrKovalenko merged 1 commit intodmtrKovalenko:mainfrom
Conversation
qu8n
commented
Apr 20, 2026
dmtrKovalenko
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes a silent no-op in the query parser:
!git:modified(and!git:clean|staged|untracked, all documented in the README) match every file instead of filtering.There's a typo in the negation path's key-alias list:
"gi"instead of"git". This causes!git:modifiedto fall through the key match -> parsed asNot(Text("git:modified"))-> no path contains that substring -> nothing filtered.Also adds
test_negation_git_status_all_key_aliasescovering all four aliases (status,st,g,git) under negation. Existing test only coveredstatus:.