feat(node & bun): Expose pageSize option

Author: dmtrKovalenko

packages/fff-bun/src/finder.ts

@@ -321,7 +321,7 @@ export class FileFinder {
       options?.maxMatchesPerFile ?? 0,
       options?.smartCase ?? true,
       options?.cursor?._offset ?? 0,
-      0, // page_limit (0 = default 50)
+      options?.pageSize ?? 0,
       options?.timeBudgetMs ?? 0,
       options?.beforeContext ?? 0,
       options?.afterContext ?? 0,
@@ -370,7 +370,7 @@ export class FileFinder {
       options.maxMatchesPerFile ?? 0,
       options.smartCase ?? true,
       options.cursor?._offset ?? 0,
-      0, // page_limit (0 = default 50)
+      options.pageSize ?? 0,
       options.timeBudgetMs ?? 0,
       options.beforeContext ?? 0,
       options.afterContext ?? 0,

packages/fff-bun/src/index.test.ts

@@ -199,6 +199,28 @@ describe("FileFinder - Full Lifecycle", () => {
     }
   });
 
+  test("grep respects pageSize option", () => {
+    // Cap to one match per file so pageSize bounds the total deterministically.
+    const unbounded = finder.grep("import", {
+      mode: "plain",
+      maxMatchesPerFile: 1,
+    });
+    expect(unbounded.ok).toBe(true);
+    if (!unbounded.ok) return;
+    expect(unbounded.value.items.length).toBeGreaterThan(2);
+
+    const limited = finder.grep("import", {
+      mode: "plain",
+      maxMatchesPerFile: 1,
+      pageSize: 2,
+    });
+    expect(limited.ok).toBe(true);
+    if (!limited.ok) return;
+    expect(limited.value.items.length).toBeLessThanOrEqual(2);
+    expect(limited.value.items.length).toBeLessThan(unbounded.value.items.length);
+    expect(limited.value.nextCursor).not.toBeNull();
+  });
+
   test("grep fuzzy mode returns results with scores", () => {
     // Intentional typo: "depdnency" instead of "dependency" to exercise fuzzy matching
     const result = finder.grep("depdnency", {

packages/fff-bun/src/types.ts

@@ -361,6 +361,8 @@ export interface GrepOptions {
   beforeContext?: number;
   /** Number of context lines to include after each match (default: 0) */
   afterContext?: number;
+  /** Maximum matches to return in this page across all files (default: 50) */
+  pageSize?: number;
 }
 
 /**
@@ -457,4 +459,6 @@ export interface MultiGrepOptions {
   beforeContext?: number;
   /** Number of context lines to include after each match (default: 0) */
   afterContext?: number;
+  /** Maximum matches to return in this page across all files (default: 50) */
+  pageSize?: number;
 }

packages/fff-node/src/finder.ts

@@ -321,7 +321,7 @@ export class FileFinder {
       options?.maxMatchesPerFile ?? 0,
       options?.smartCase ?? true,
       options?.cursor?._offset ?? 0,
-      0, // page_limit (0 = default 50)
+      options?.pageSize ?? 0,
       options?.timeBudgetMs ?? 0,
       options?.beforeContext ?? 0,
       options?.afterContext ?? 0,
@@ -370,7 +370,7 @@ export class FileFinder {
       options.maxMatchesPerFile ?? 0,
       options.smartCase ?? true,
       options.cursor?._offset ?? 0,
-      0, // page_limit (0 = default 50)
+      options.pageSize ?? 0,
       options.timeBudgetMs ?? 0,
       options.beforeContext ?? 0,
       options.afterContext ?? 0,

packages/fff-node/src/types.ts

@@ -364,6 +364,8 @@ export interface GrepOptions {
    * without a TS-side regex port. (default: false)
    */
   classifyDefinitions?: boolean;
+  /** Maximum matches to return in this page across all files (default: 50) */
+  pageSize?: number;
 }
 
 /**
@@ -467,4 +469,6 @@ export interface MultiGrepOptions {
    * and expose it via `GrepMatch.isDefinition`. (default: false)
    */
   classifyDefinitions?: boolean;
+  /** Maximum matches to return in this page across all files (default: 50) */
+  pageSize?: number;
 }

packages/fff-node/test/e2e.mjs

@@ -170,6 +170,29 @@ describe("fff-node", { concurrency: 1 }, () => {
       }
     });
 
+    it("respects pageSize", () => {
+      // Cap to one match per file so pageSize bounds the total deterministically.
+      const unbounded = finder.grep("fn", { mode: "plain", maxMatchesPerFile: 1 });
+      assert.ok(unbounded.ok, `grep failed: ${!unbounded.ok ? unbounded.error : ""}`);
+      assert.ok(unbounded.value.items.length > 2);
+
+      const limited = finder.grep("fn", {
+        mode: "plain",
+        maxMatchesPerFile: 1,
+        pageSize: 2,
+      });
+      assert.ok(limited.ok, `grep failed: ${!limited.ok ? limited.error : ""}`);
+      assert.ok(
+        limited.value.items.length <= 2,
+        `expected <=2 items, got ${limited.value.items.length}`,
+      );
+      assert.ok(
+        limited.value.items.length < unbounded.value.items.length,
+        "limited page should yield fewer matches than the default",
+      );
+      assert.ok(limited.value.nextCursor !== null, "nextCursor should be set");
+    });
+
     it("regex mode matches pub fn declarations", () => {
       const r = finder.grep("pub fn \\w+", { mode: "regex" });
       assert.ok(r.ok, `regex grep failed: ${!r.ok ? r.error : ""}`);

packages/pi-fff/src/index.ts

@@ -455,8 +455,7 @@ export default function fffExtension(pi: ExtensionAPI) {
     if (!shouldEnableMentions()) return;
 
     ctx.ui.setEditorComponent(
-      (tui: any, theme: any, keybindings: any) =>
-        new FffEditor(tui, theme, keybindings),
+      (tui: any, theme: any, keybindings: any) => new FffEditor(tui, theme, keybindings),
     );
   }