Fix: Exit insert mode and cleanup buffers when closing picker#10
Merged
Conversation
dmtrKovalenko
approved these changes
Aug 2, 2025
Owner
|
Thank you so much for a contribution. Changes make a lot of sense! |
Owner
|
Could you quickly run stylua? I’d love to merge it just not near the computer rn |
Owner
|
It’s hard for me rn because I know that this unlocks certain flows but I really need to test the solution. I’m just thinking won’t it cause much more significant load time? probably I’ll merge it rn even with CI failures to unfuck the current state of things and will revisit it tonight. Same for ci |
Contributor
Author
|
anytime bro thank you for creating this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes three related issues with the file picker:
Changes
vim.cmd('stopinsert')in theselectfunction before closing the pickervim.cmd('stopinsert')at the beginning of theclosefunctionclosefunction to delete all created buffersTesting
<C-p><Esc>- you return to normal mode ✓:q\!- no E37 error ✓Fixes #8