Skip to content

fix!: Frecency conflicts (sorry, this will delete all your history)#104

Merged
dmtrKovalenko merged 1 commit into
mainfrom
fix/frecency-conflicts
Aug 13, 2025
Merged

fix!: Frecency conflicts (sorry, this will delete all your history)#104
dmtrKovalenko merged 1 commit into
mainfrom
fix/frecency-conflicts

Conversation

@dmtrKovalenko
Copy link
Copy Markdown
Owner

No description provided.

@dmtrKovalenko dmtrKovalenko requested a review from Copilot August 13, 2025 21:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the frecency tracking system by removing the FileKey abstraction and simplifying file access tracking to work directly with file paths. The change improves the API design by using native path types and adds better error handling for invalid paths.

  • Removes the FileKey wrapper struct and uses Path/PathBuf directly
  • Renames access_file to track_access for better clarity
  • Adds path canonicalization and validation with proper error handling

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
lua/fff/rust/lib.rs Updates function signature and removes FileKey usage in track_access
lua/fff/rust/frecency.rs Refactors to use Path directly and adds path validation
lua/fff/rust/file_picker.rs Removes FileKey conversion methods and updates to use paths directly
lua/fff/rust/file_key.rs Completely removes the FileKey struct
lua/fff/picker_ui.lua Removes old access_file call (logic moved elsewhere)
lua/fff/main.lua Updates to use async file operations and new track_access function
lua/fff/fuzzy.lua Updates exported function name from access_file to track_access
lua/fff/file_picker/init.lua Renames function and adds debug print statement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread lua/fff/file_picker/init.lua Outdated
Comment thread lua/fff/rust/frecency.rs
@dmtrKovalenko dmtrKovalenko force-pushed the fix/frecency-conflicts branch 3 times, most recently from 45c921e to 1b1ba31 Compare August 13, 2025 21:57
@dmtrKovalenko dmtrKovalenko force-pushed the fix/frecency-conflicts branch from 1b1ba31 to d61acd6 Compare August 13, 2025 22:18
@dmtrKovalenko dmtrKovalenko merged commit 4e1a94c into main Aug 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants