Skip to content

feat(image): add terminal support check via snacks#35

Closed
rachartier wants to merge 1 commit into
dmtrKovalenko:mainfrom
rachartier:main
Closed

feat(image): add terminal support check via snacks#35
rachartier wants to merge 1 commit into
dmtrKovalenko:mainfrom
rachartier:main

Conversation

@rachartier
Copy link
Copy Markdown
Contributor

Hello,

Ghostty and Wezterm also supports displaying images with Snacks.image and with Kitty's kitten icat.

I think it is better to simply call snacks.image without even checking if the terminal is supported, as Snacks already does this: https://github.com/folke/snacks.nvim/blob/main/lua/snacks/image/buf.lua#L9 with https://github.com/folke/snacks.nvim/blob/main/lua/snacks/image/init.lua#L212.

So it is quite redundant to do this check again, as you verify exactly this with success and placement variable in your M.display_image function.

What do you think?

@dmtrKovalenko
Copy link
Copy Markdown
Owner

I wasn't able to push into your repository so I created another PR with your commit preserved #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants