feat(image): add terminal support check via snacks#35
Closed
rachartier wants to merge 1 commit into
Closed
Conversation
Owner
|
I wasn't able to push into your repository so I created another PR with your commit preserved #50 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Ghostty and Wezterm also supports displaying images with Snacks.image and with Kitty's kitten icat.
I think it is better to simply call
snacks.imagewithout even checking if the terminal is supported, as Snacks already does this: https://github.com/folke/snacks.nvim/blob/main/lua/snacks/image/buf.lua#L9 with https://github.com/folke/snacks.nvim/blob/main/lua/snacks/image/init.lua#L212.So it is quite redundant to do this check again, as you verify exactly this with
successandplacementvariable in yourM.display_imagefunction.What do you think?