fix: use vim.fn.type() to detect Blobs in grep renderer#386
Open
gtr wants to merge 1 commit intodmtrKovalenko:mainfrom
Open
fix: use vim.fn.type() to detect Blobs in grep renderer#386gtr wants to merge 1 commit intodmtrKovalenko:mainfrom
gtr wants to merge 1 commit intodmtrKovalenko:mainfrom
Conversation
gtr
force-pushed
the
fix/grep-renderer-blob-detection
branch
from
6254b71 to
75c3c87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lua's
type()returns "string" for Vim Blobs so the existing guard online_contentnever fires. This causes E976 (Blob as String) whenstrdisplaywidthreceives a Blob fromvim.json.decode.This commit uses
vim.fn.type() == vim.v.t_blobinstead which correctly identifies Blobs, then converts to a proper Lua string viablob2list. Fixes #310 - the previous fix on #342 was insufficient.