security: fix shell injection vulnerabilities in file path handling#41
Merged
dmtrKovalenko merged 1 commit intoAug 4, 2025
Merged
Conversation
Replace unsafe string.format() calls with vim.fn.shellescape() to prevent command injection when file paths contain special characters.
dmtrKovalenko
approved these changes
Aug 4, 2025
Owner
|
thank you for noting and fixing this, this is amazing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes shell injection vulnerabilities in file path handling where malicious file names could potentially execute arbitrary commands.
What was the issue?
A few system command calls were using unescaped file paths, which could be problematic if someone created files with special shell characters in their names.
For example, a file named
image.jpg; rm -rf /could cause issues when the picker tries to preview it.What changed?
Updated 5 system command calls across 2 files to use
vim.fn.shellescape()for proper path escaping:lua/fff/file_picker/image.luafileandidentifycommands inget_image_dimensions()lua/fff/file_picker/preview.luatailcommand inread_file_tail()fileandxxdcommands inpreview_binary_file()The fix:
Testing