Skip to content

security: fix shell injection vulnerabilities in file path handling #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmtrKovalenko merged 1 commit into from
Aug 4, 2025
Merged

security: fix shell injection vulnerabilities in file path handling #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lua/fff/file_picker/image.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ end
--- @return number|nil, number|nil Width and height in pixels
function M.get_image_dimensions(file_path)
-- Try file command first
local cmd = string.format('file "%s"', file_path)
local cmd = string.format('file %s', vim.fn.shellescape(file_path))
local result = vim.fn.system(cmd)

if vim.v.shell_error == 0 then
Expand All @@ -167,7 +167,7 @@ function M.get_image_dimensions(file_path)
end

-- Fallback to identify command (ImageMagick)
cmd = string.format('identify -format "%%w %%h" "%s" 2>/dev/null', file_path)
cmd = string.format('identify -format "%%w %%h" %s 2>/dev/null', vim.fn.shellescape(file_path))
result = vim.fn.system(cmd)

if vim.v.shell_error == 0 then
Expand Down
6 changes: 3 additions & 3 deletions lua/fff/file_picker/preview.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ end
--- @return table|nil Lines of content, nil if failed
function M.read_file_tail(file_path, tail_lines)
-- Use system tail command for efficiency
local cmd = string.format('tail -n %d "%s" 2>/dev/null', tail_lines, file_path)
local cmd = string.format('tail -n %d %s 2>/dev/null', tail_lines, vim.fn.shellescape(file_path))
local result = vim.fn.system(cmd)

if vim.v.shell_error ~= 0 then
Expand Down Expand Up @@ -488,7 +488,7 @@ function M.preview_binary_file(file_path, bufnr, info, file)

-- Try to get more information about the binary file
if vim.fn.executable('file') == 1 then
local cmd = string.format('file -b "%s"', file_path)
local cmd = string.format('file -b %s', vim.fn.shellescape(file_path))
local result = vim.fn.system(cmd)
if vim.v.shell_error == 0 and result then
result = result:gsub('\n', '')
Expand All @@ -502,7 +502,7 @@ function M.preview_binary_file(file_path, bufnr, info, file)
table.insert(lines, 'Hex dump (first 1KB):')
table.insert(lines, '')

local cmd = string.format('xxd -l 1024 "%s"', file_path)
local cmd = string.format('xxd -l 1024 %s', vim.fn.shellescape(file_path))
local hex_result = vim.fn.system(cmd)
if vim.v.shell_error == 0 and hex_result then
local hex_lines = vim.split(hex_result, '\n')
Expand Down
Loading