Fix watcher leak in picker#51
Conversation
| if buf and vim.api.nvim_buf_is_valid(buf) then vim.api.nvim_buf_delete(buf, { force = true }) end | ||
| end | ||
|
|
||
| main.stop_background_monitor() |
There was a problem hiding this comment.
This is not an option to do because we have to keep the sync running in the background, we should clean it up when the neovim is requested to exit but I've been sure that it should already be cleaned up let me research this a little bit
There was a problem hiding this comment.
Yeah the problem is that it seems to spawn multiple of these processes (one on each use of the finder). And they never die until the editor is closed.
I do however now wonder if this actual is a valid fix, cause now I have an instance taking 4GB of memory again.
This is a bit hard to verify if a fix is working or not.
There was a problem hiding this comment.
they spawning once per neovim session (at least they should be) I will try to wrap my head around this more deeply can you share the platform info
There was a problem hiding this comment.
I am on Linux, kernel 6.15.8, alacritty terminal, Neovim v0.11.3
|
I debugged it a little bit more and apperently I misread the docs of notify rs and missed the idea that they spawn their own debouncer thread which led to the hanging threads by debouncer. After this PR everything should be good #56 |
2 participants
Closes #49